From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viktor Rosenfeld Subject: Re: [PATCH] Improve configurability of ox-koma-letter Date: Sun, 5 May 2013 15:25:11 +0200 Message-ID: <20130505132511.GA2898@kenny.local> References: <20130421175957.GA7821@cartman> <87ppxnkl4d.fsf@gmail.com> <20130422105742.GD7821@cartman> <20130422191448.GC725@kenny.fritz.box> <20130423095058.GB685@kenny.fritz.box> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="YZ5djTAD1cGYuMQK" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:40372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYywJ-0002Hd-PT for emacs-orgmode@gnu.org; Sun, 05 May 2013 09:25:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UYywI-0005fu-TL for emacs-orgmode@gnu.org; Sun, 05 May 2013 09:25:19 -0400 Received: from mail-bk0-x22b.google.com ([2a00:1450:4008:c01::22b]:40943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYywI-0005fm-Ly for emacs-orgmode@gnu.org; Sun, 05 May 2013 09:25:18 -0400 Received: by mail-bk0-f43.google.com with SMTP id jm19so1247463bkc.2 for ; Sun, 05 May 2013 06:25:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Alan Schmitt Cc: emacs-orgmode@gnu.org --YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Alan, I've removed the defaults from OPENING and CLOSING. See the attached patch. Cheers, Viktor Alan Schmitt wrote: > Viktor Rosenfeld writes: > > > Rasmus also suggested setting the default opening and closing to nil > > because we should not assume that everybody speaks English. Maybe, every > > variable should default to nil. > > Yes, I think it's a good idea. I often have lines that set the opening > and closing to '~' to avoid having them. > > Alan > --YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-ox-koma-letter.el-No-default-opening-and-closing-lin.patch" >From 1455bc78d87649ff2b41760f382c20fae4ecd585 Mon Sep 17 00:00:00 2001 From: Viktor Rosenfeld Date: Sun, 5 May 2013 15:11:15 +0200 Subject: [PATCH 1/2] ox-koma-letter.el: No default opening and closing line. * ox-koma-letter.el (org-koma-letter-opening): No default / set to nil. (org-koma-letter-closing): No default / set to nil. We should not assume a formal English opening and closing line. A letter requires many personal options, such as the address, so it is no more work to also these options. TINYCHANGE --- contrib/lisp/ox-koma-letter.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/lisp/ox-koma-letter.el b/contrib/lisp/ox-koma-letter.el index 31ccd89..37ff903 100644 --- a/contrib/lisp/ox-koma-letter.el +++ b/contrib/lisp/ox-koma-letter.el @@ -105,12 +105,12 @@ :group 'org-export-koma-letter :type 'string) -(defcustom org-koma-letter-opening "Dear Madam or Sir," +(defcustom org-koma-letter-opening nil "Letter's opening, as a string." :group 'org-export-koma-letter :type 'string) -(defcustom org-koma-letter-closing "Sincerely yours," +(defcustom org-koma-letter-closing nil "Koma-Letter's closing, as a string." :group 'org-export-koma-letter :type 'string) -- 1.8.2.2 --YZ5djTAD1cGYuMQK--