From mboxrd@z Thu Jan  1 00:00:00 1970
From: Viktor Rosenfeld <listuser36@gmail.com>
Subject: Re: [PATCH] Improve configurability of ox-koma-letter
Date: Tue, 23 Apr 2013 12:09:20 +0200
Message-ID: <20130423100920.GC685@kenny.fritz.box>
References: <20130421175957.GA7821@cartman> <m2li8b6khn.fsf@polytechnique.org>
	<87ppxnkl4d.fsf@gmail.com> <m2k3nu7vz8.fsf@polytechnique.org>
	<20130422105742.GD7821@cartman> <m2haiy7os3.fsf@polytechnique.org>
	<20130422191448.GC725@kenny.fritz.box>
	<m2ehe13dvh.fsf@polytechnique.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:57378)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <listuser36@gmail.com>) id 1UUaAH-0007Fg-RW
	for emacs-orgmode@gnu.org; Tue, 23 Apr 2013 06:09:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <listuser36@gmail.com>) id 1UUaAG-00012p-Cc
	for emacs-orgmode@gnu.org; Tue, 23 Apr 2013 06:09:33 -0400
Received: from mail-bk0-x231.google.com ([2a00:1450:4008:c01::231]:42282)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <listuser36@gmail.com>) id 1UUaAG-00010o-0J
	for emacs-orgmode@gnu.org; Tue, 23 Apr 2013 06:09:32 -0400
Received: by mail-bk0-f49.google.com with SMTP id w5so180613bku.36
	for <emacs-orgmode@gnu.org>; Tue, 23 Apr 2013 03:09:31 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <m2ehe13dvh.fsf@polytechnique.org>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Alan Schmitt <alan.schmitt@polytechnique.org>
Cc: emacs-orgmode@gnu.org

Hi Alan,

Alan Schmitt wrote:

> I've applied the patch. I propose a further tiny improvement:
> ,----
> | --- a/contrib/lisp/ox-koma-letter.el
> | +++ b/contrib/lisp/ox-koma-letter.el
> | @@ -273,7 +273,7 @@ holding export options."
> |        (when email (format "\\setkomavar{fromemail}{%s}\n" email))
> |        (when signature (format "\\setkomavar{signature}{%s}\n" signature))))
> |     ;; Date.
> | -   (format "\\date{%s}\n" (org-export-data (org-export-get-date info) info))
> | +   (format "\\setkomavar{date}{%s}\n" (org-export-data (org-export-get-date info) info))
> |     ;; Place
> |     (let ((with-place (plist-get info :with-place))
> |          (place (plist-get info :place)))
> `----
> 
> It seems that the date is not picked up by the letter unless it's in a
> koma var. I can commit this if you think it's correct.

I can't reproduce your error. The date KOMA variable is automatically
set by the \date LaTeX command which can be verified by the snipplet
below. Out of curiosity, what TeX version are you using? I use TeX Live
2012 which includes scrlttr2 2012/07/29 v3.11b.

In any case, the KOMA-Script guide also uses the KOMA variable in its
examples, so I think your patch is fine.

Cheers,
Viktor

#+BEGIN_SRC latex
\documentclass{scrlttr2}
\usepackage[english,ngerman]{babel}
\LoadLetterOption{DIN}
\date{21. April 2013}
\begin{document}
\begin{letter}{Address}
\opening{Opening}

The date: \usekomavar{date}

\closing{Closing}
\end{letter}
\end{document}
#+END_SRC

> 
> Thanks,
> 
> Alan
>