From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rick Frankel Subject: Re: [ANN] Merge of new export framework on Wednesday Date: Sun, 3 Mar 2013 20:50:51 -0500 Message-ID: <20130304015051.GC45961@BigDog.local> References: <876229nrxf.fsf@gmail.com> <87ppzh1xg0.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([208.118.235.92]:50278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCKYL-00057p-TA for emacs-orgmode@gnu.org; Sun, 03 Mar 2013 20:51:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UCKYH-0000MN-7K for emacs-orgmode@gnu.org; Sun, 03 Mar 2013 20:50:57 -0500 Received: from [204.62.15.78] (port=46045 helo=mail.rickster.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UCKYH-0000MI-3i for emacs-orgmode@gnu.org; Sun, 03 Mar 2013 20:50:53 -0500 Received: from BigDog.local (pool-72-89-40-63.nycmny.fios.verizon.net [72.89.40.63]) by mail.rickster.com (Postfix) with ESMTPS id DD32720B7B for ; Sun, 3 Mar 2013 20:50:52 -0500 (EST) Content-Disposition: inline In-Reply-To: <87ppzh1xg0.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Bastien- On Sat, Mar 02, 2013 at 07:14:07PM +0100, Bastien wrote: > Done. You can now use HTML_HEAD instead of HTML_STYLE. > > Some variables were also renamed, check the details here: > http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=2752ef In trying to migrate these changes to the slide exporters, i noticed some confusion w/ the migration of html-style vs. html-style-extra: - (:html-style nil nil org-html-style) - (:html-style-extra "HTML_STYLE" nil org-html-style-extra newline) - (:html-style-include-default nil nil org-html-style-include-default) - (:html-style-include-scripts nil nil org-html-style-include-scripts) + (:html-head "HTML_HEAD" nil org-html-head newline) + (:html-style-include-default nil nil org-html-head-include-default-style) + (:html-head-include-scripts nil nil org-html-head-include-scripts) ... - exp-plist :html-style-extra - (concat (or (plist-get exp-plist :html-style-extra) "") + exp-plist :html-head-extra + (concat (or (plist-get exp-plist :html-head-extra) "") "\n" style))))) Specifically, - :html-style was renamed to :html-head (ok), but the in-buffer property HTML_HEAD was added to this export property. - :html-style-extra was (which was associated w/t the in-buffer property HTML_STYLE) was removed from the export prop list (but is referenced later in the code. - `org-html-head-extra' is mentioned in a doc string but never defined. I think this is a bug/typo. Wouldn't the following be closer to a straight renaming: (:html-head nil nil org-html-head newline) (:html-head-extra HTML_HEAD nil org-html-head-extra newline) or should {org-,:}html-head-extra be dropped entirely? Also, shouldn't :html-style-include-default be :html-head-include-default? rick