emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Rick Frankel <rick@rickster.com>
To: emacs-orgmode@gnu.org
Subject: Re: [ANN] Merge of new export framework on Wednesday
Date: Sun, 3 Mar 2013 20:50:51 -0500	[thread overview]
Message-ID: <20130304015051.GC45961@BigDog.local> (raw)
In-Reply-To: <87ppzh1xg0.fsf@bzg.ath.cx>

Bastien-

On Sat, Mar 02, 2013 at 07:14:07PM +0100, Bastien wrote:
> Done.  You can now use HTML_HEAD instead of HTML_STYLE.
> 
> Some variables were also renamed, check the details here:
> http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=2752ef

In trying to migrate these changes to the slide exporters, i noticed
some confusion w/ the migration of html-style vs. html-style-extra:

-   (:html-style nil nil org-html-style)
-   (:html-style-extra "HTML_STYLE" nil org-html-style-extra newline)
-   (:html-style-include-default nil nil org-html-style-include-default)
-   (:html-style-include-scripts nil nil org-html-style-include-scripts)
+   (:html-head "HTML_HEAD" nil org-html-head newline)
+   (:html-style-include-default nil nil org-html-head-include-default-style)
+   (:html-head-include-scripts nil nil org-html-head-include-scripts)
...
-		    exp-plist :html-style-extra
-		    (concat (or (plist-get exp-plist :html-style-extra) "")
+		    exp-plist :html-head-extra
+		    (concat (or (plist-get exp-plist :html-head-extra) "")
 			    "\n"
 			    style)))))
Specifically,

        - :html-style was renamed to :html-head (ok), but the
        in-buffer property HTML_HEAD was added to this export
        property.

        - :html-style-extra was (which was associated w/t the
        in-buffer property HTML_STYLE) was removed from the export
        prop list (but is referenced later in the code.
        - `org-html-head-extra' is mentioned in a doc string but never
        defined.

I think this is a bug/typo. Wouldn't the following be closer to a
straight renaming:

         (:html-head nil nil org-html-head newline)
         (:html-head-extra HTML_HEAD nil org-html-head-extra newline)

or should {org-,:}html-head-extra be dropped entirely?

Also, shouldn't :html-style-include-default be
:html-head-include-default?

rick

  parent reply	other threads:[~2013-03-04  1:51 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-03 19:00 [ANN] Merge of new export framework on Wednesday Nicolas Goaziou
2013-02-03 20:59 ` François Allisson
2013-02-04  9:17 ` Detlef Steuer
2013-02-04 13:49   ` David Bjergaard
2013-02-04 21:56     ` Suvayu Ali
2013-02-05  1:07       ` Eric S Fraga
2013-02-05  7:41         ` Suvayu Ali
2013-02-05  9:25           ` Eric S Fraga
2013-02-05 11:18             ` Suvayu Ali
2013-02-05 12:50               ` Eric S Fraga
2013-02-05 13:07                 ` Suvayu Ali
2013-03-04 15:20                   ` Suvayu Ali
2013-02-04 23:05   ` Bastien
2013-02-04 13:35 ` Rasmus
2013-02-05 16:30 ` org export Taskjuggler (was: Re: [ANN] Merge of new export framework on Wednesday - ) Giovanni Ridolfi
2013-02-05 17:59   ` org export Taskjuggler Nicolas Goaziou
2013-02-07 10:21     ` Christian Egli
2013-02-07 10:43       ` Jambunathan K
2013-02-07 13:13       ` Nicolas Goaziou
2013-02-07  0:14 ` [ANN] Merge of new export framework on Wednesday Jay Kerns
2013-02-08 15:53 ` Sean O'Halpin
2013-02-08 16:45   ` Sebastien Vauban
2013-02-09 13:20     ` Sean O'Halpin
2013-02-09 13:56       ` Nicolas Goaziou
2013-02-09 18:14         ` Sean O'Halpin
2013-02-09 18:49           ` Nicolas Goaziou
2013-02-09 20:55             ` Nicolas Richard
2013-03-02 18:14   ` Bastien
2013-03-02 21:11     ` Sebastien Vauban
2013-03-03  5:35       ` Bastien
2013-03-03 12:25     ` Sean O'Halpin
2013-03-03 17:09       ` Bastien
2013-03-04  1:50     ` Rick Frankel [this message]
2013-03-04  6:57       ` Bastien
2013-03-04  9:09       ` T.F. Torrey
2013-03-04 15:19     ` Mike McLean
2013-03-04 15:24       ` Nicolas Goaziou
2013-03-04 16:12         ` Mike McLean
2013-03-04 16:30           ` Nicolas Goaziou
2013-03-04 16:44             ` Mike McLean
2013-03-04 15:28     ` Suvayu Ali
2013-03-04 17:44       ` Bastien
2013-02-09  8:03 ` Achim Gratz
2013-02-09  8:21   ` Nicolas Goaziou
2013-02-09  9:26   ` Bastien
2013-02-09 10:33     ` Achim Gratz
2013-02-09 10:44       ` Nicolas Goaziou
2013-02-09 10:49         ` Bastien
2013-02-09 15:01   ` Jambunathan K
2013-02-09 17:16   ` compilation issues of new export framework Achim Gratz
2013-02-09 17:50     ` Nicolas Goaziou
2013-02-09 18:02       ` Achim Gratz
2013-02-10 10:44       ` Achim Gratz
2013-02-10 12:53         ` Nicolas Goaziou
2013-02-10 15:53           ` Nicolas Goaziou
2013-02-11  7:49             ` Achim Gratz
2013-02-11 20:18               ` Nicolas Goaziou
2013-02-11 20:30                 ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130304015051.GC45961@BigDog.local \
    --to=rick@rickster.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).