From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toby Cubitt Subject: Re: [PATCH] Separate clocksum format for durations >= 1 day Date: Sat, 17 Nov 2012 17:02:04 +0100 Message-ID: <20121117160204.GA27446@c3po> References: <87lie0nve7.fsf@gmail.com> Reply-To: Toby Cubitt Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([208.118.235.92]:42346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZkq6-0003Ft-Ds for emacs-orgmode@gnu.org; Sat, 17 Nov 2012 11:01:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZkq3-0004S2-Bg for emacs-orgmode@gnu.org; Sat, 17 Nov 2012 11:01:50 -0500 Received: from starfish.geekisp.com ([216.168.135.166]:39480) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1TZkq3-0004RP-6O for emacs-orgmode@gnu.org; Sat, 17 Nov 2012 11:01:47 -0500 Content-Disposition: inline In-Reply-To: <87lie0nve7.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org On Sat, Nov 17, 2012 at 03:42:24PM +0100, Nicolas Goaziou wrote: > Toby Cubitt writes: > > > I've replaced the cons cells with additional plist properties, as you > > suggested. The resulting customization ui still isn't wonderful in my > > opinion. But it does the job, and I'm not sure how much scope there is > > for improving it further. If you see a way, by all means feel free to > > make the changes yourself. I really don't mind what format you go with > > for org-time-clocksum-format, as long as it supports the new formatting > > features implemented in the patch. > > Considering I'm not an expert in customize ui, it's good enough as it > is. OK. If someone thinks of a way to improve the customization ui (keeping the same data type), it's easy to change it later without breaking anything. > I've applied your patch (with some small changes in a docstring). Thank > you again for all that work. Glad we finally found a good implementation. Thanks to you for all your helpful feedback. Toby -- Dr T. S. Cubitt Mathematics and Quantum Information group Department of Mathematics Complutense University Madrid, Spain email: tsc25@cantab.net web: www.dr-qubit.org