emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Fix bug in org-agenda-diary-sexp-prefix
@ 2012-10-26 12:27 Toby Cubitt
  2012-10-26 12:46 ` Bastien
  0 siblings, 1 reply; 2+ messages in thread
From: Toby Cubitt @ 2012-10-26 12:27 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

The commit message in the attached patch explains the problem, and the
simple fix.

Toby
-- 
Dr T. S. Cubitt
Mathematics and Quantum Information group
Department of Mathematics
Complutense University
Madrid, Spain

email: tsc25@cantab.net
web:   www.dr-qubit.org

[-- Attachment #2: 0001-Fix-bug-in-org-agenda-diary-sexp-prefix.patch --]
[-- Type: text/x-patch, Size: 1013 bytes --]

From b777c7ca29c74476893dd62599c344c0ff5998e6 Mon Sep 17 00:00:00 2001
From: "Toby S. Cubitt" <tsc25@cantab.net>
Date: Fri, 26 Oct 2012 14:06:28 +0200
Subject: [PATCH] Fix bug in org-agenda-diary-sexp-prefix

* lisp/org-agenda.el (org-agenda-get-sexps): reset `extra' to nil at
beginning of re-search-forward loop, otherwise next iteration picks up
`extra' value from previous entry.
---
 lisp/org-agenda.el |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index b9588bb..a2ed3b6 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -5482,7 +5482,8 @@ Do we have a reason to ignore this TODO entry because it has a time stamp?
 		tags (save-excursion (org-backward-heading-same-level 0)
 				     (org-get-tags-at))
 		todo-state (org-get-todo-state)
-		warntime (org-entry-get (point) "APPT_WARNTIME"))
+		warntime (org-entry-get (point) "APPT_WARNTIME")
+		extra nil)
 
 	  (dolist (r (if (stringp result)
 			 (list result)
-- 
1.7.8.6


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix bug in org-agenda-diary-sexp-prefix
  2012-10-26 12:27 [PATCH] Fix bug in org-agenda-diary-sexp-prefix Toby Cubitt
@ 2012-10-26 12:46 ` Bastien
  0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2012-10-26 12:46 UTC (permalink / raw)
  To: emacs-orgmode

Hi Toby,

Toby Cubitt <tsc25@cantab.net> writes:

> The commit message in the attached patch explains the problem, and the
> simple fix.

Applied, thanks!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-26 13:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-26 12:27 [PATCH] Fix bug in org-agenda-diary-sexp-prefix Toby Cubitt
2012-10-26 12:46 ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).