From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toby Cubitt Subject: Re: bug#11249: 24.1.50; Overlay with face property causes calendar buffer to scroll Date: Sun, 22 Apr 2012 12:05:03 +0200 Message-ID: <20120422100503.GA23154@c3po.home> References: <874nsctgb8.fsf@gnu.org> Reply-To: Toby Cubitt Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([208.118.235.92]:57577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SLtfi-00015y-PE for emacs-orgmode@gnu.org; Sun, 22 Apr 2012 06:05:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SLtfg-0003IH-Ua for emacs-orgmode@gnu.org; Sun, 22 Apr 2012 06:05:34 -0400 Received: from sanddollar.geekisp.com ([216.168.135.167]:1439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SLtfg-0003HP-Qa for emacs-orgmode@gnu.org; Sun, 22 Apr 2012 06:05:32 -0400 Content-Disposition: inline In-Reply-To: <874nsctgb8.fsf@gnu.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org On Sun, Apr 22, 2012 at 08:46:03AM +0200, Bastien wrote: > Toby Cubitt writes: > > Was there some reason to reject Eli's suggested fix of enlarging the > > calendar window by 1 line? As it stands, if anyone customizes the new > > org-date-selected face to be bold (the highlighted date *is* a little > > less visible now), it will cause the same problem as before. And the fact > > that it's caused by making the font bold is not at all obvious...at > > least, it wasn't obvious to me! Eli's fix works more generally. > > This general solution comes with a cost -- enlarging the window by > one-line for everyone just because a few users will use bold fonts and > have a problem while displaying... does not feel right to me. Fair enough. > > Anyway, since I now know how to patch things if I do decide I want a bold > > font, it's not a big issue for me. > > > > In the patch I posted, I also took the opportunity to set `cursor-type' > > to nil when opening the calendar in `org-read-date'. The cursor obscures > > one digit of the selected date, making that bit harder to read (as well > > as looking ugly). Did you intend to reject this change too? > > I did because I found the not-bold-anymore face wasn't visible enough, > and the shallow cursor made it visible. > > I use inverse-video now for this face, so cursor-type nil is okay, > I applied a patch with this. Inverse-video is a good solution - thanks! Toby -- Dr T. S. Cubitt Mathematics and Quantum Information group Department of Mathematics Complutense University Madrid, Spain email: tsc25@cantab.net web: www.dr-qubit.org