From mboxrd@z Thu Jan  1 00:00:00 1970
From: Viktor Rosenfeld <listuser36@googlemail.com>
Subject: Re: BUG: org-todo-yesterday logs wrong date
Date: Sat, 12 Nov 2011 00:55:22 +0100
Message-ID: <20111111235522.GA30554@kenny.fritz.box>
References: <20111018231721.GA22432@kenny.fritz.box>
	<CAE1ac0koF_OvaGnEghq2S7nm8ttZU4yo0wAeUOBj_Fmj14Be4w@mail.gmail.com>
	<877h3af30t.fsf@norang.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([140.186.70.92]:52401)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <listuser36@googlemail.com>) id 1RP0wd-0002VZ-30
	for emacs-orgmode@gnu.org; Fri, 11 Nov 2011 18:55:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <listuser36@googlemail.com>) id 1RP0wb-0008MG-KS
	for emacs-orgmode@gnu.org; Fri, 11 Nov 2011 18:55:38 -0500
Received: from mail-bw0-f41.google.com ([209.85.214.41]:37471)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <listuser36@googlemail.com>) id 1RP0wb-0008M2-9I
	for emacs-orgmode@gnu.org; Fri, 11 Nov 2011 18:55:37 -0500
Received: by bke17 with SMTP id 17so3128236bke.0
	for <emacs-orgmode@gnu.org>; Fri, 11 Nov 2011 15:55:36 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <877h3af30t.fsf@norang.ca>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Bernt Hansen <bernt@norang.ca>
Cc: John Wiegley <johnw@newartisans.com>, emacs-orgmode@gnu.org

Hi Bernt,

Bernt Hansen wrote:

> Geert Kloosterman <g.j.kloosterman@gmail.com> writes:
> 
> > Hi all,
> >
> > On Wed, Oct 19, 2011 at 1:17 AM, Viktor Rosenfeld <
> > listuser36@googlemail.com> wrote:
> >
> >    
> >     org-todo-yesterday and org-agenda-todo-yesterday log a note using
> >     the
> >     current timestamp and not a timestamp of 23:59 of yesterday's
> >     date.
> >    
> >     I'm using Org-Mode 7.7 pulled today from the git repository.
> >    
> >
> >
> > I'm experiencing the same problem with the org-mode version I pulled
> > from git today. 
> >
> > Switching back to the 7.7 tarball fixes the problem.
> >
> > Best regards,
> > Geert Kloosterman
> >  
> 
> Git bisect identifies the following commit as the source of this
> problem.
> 
> 7d2d8f884b2e22e3056553ea68858fe4fc674427 is the first bad commit
> commit 7d2d8f884b2e22e3056553ea68858fe4fc674427
> Author: John Wiegley <johnw@newartisans.com>
> Date:   Sat Aug 13 03:21:49 2011 -0500
> 
>     Add customization variable `org-use-effective-time'
>     
>     If non-nil, consider `org-extend-today-until' when creating timestamps.
>     For example, if `org-extend-today-until' is 8, and it's 4am, then the
>     "effective time" of any timestamps between midnight and 8am will be
>     23:59 of the previous day.
> 
> :040000 040000 a33f65040163763ed06996b9ffc18bcfc5884457 0782571b08e0a128fa3b072b8b8edf177c001ca3 M	lisp
> 
> Regards,
> Bernt

Thanks for the info. Setting org-use-effective-time to 1 fixes the
problem, even if org-extend-today-until is zero. I'm curious though why
its type is integer and not boolean.

Thanks again,
Viktor