From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: [Accepted] Add source subtree which will be refiled Date: Fri, 14 Oct 2011 11:20:54 +0200 (CEST) Message-ID: <20111014092054.3FB29621EB2@carsten-dominiks-macbook-pro.local> References: <80lisogetx.fsf@somewhere.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([140.186.70.92]:41042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGCKu-0006nN-TG for emacs-orgmode@gnu.org; Tue, 18 Oct 2011 12:16:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGCKt-0002Zh-Dt for emacs-orgmode@gnu.org; Tue, 18 Oct 2011 12:16:16 -0400 Received: from smtp2.infopact.nl ([212.29.160.180]:43611 helo=mc-smtp1.infopact.nl) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGCKt-0002ZI-0M for emacs-orgmode@gnu.org; Tue, 18 Oct 2011 12:16:15 -0400 Received: from carsten-dominiks-macbook-pro.local (238-136-35-84.infopact.nl [84.35.136.238]) by mc-smtp1.infopact.nl (8.14.3/8.14.3) with ESMTP id p9IGGAi3017570 for ; Tue, 18 Oct 2011 18:16:12 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Patch 989 (http://patchwork.newartisans.com/patch/989/) is now "Accepted". Maintainer comment: none This relates to the following submission: http://mid.gmane.org/%3C80lisogetx.fsf%40somewhere.org%3E Here is the original message containing the patch: > Content-Type: text/plain; charset="utf-8" > MIME-Version: 1.0 > Content-Transfer-Encoding: 7bit > Subject: [O] Add source subtree which will be refiled > Date: Fri, 14 Oct 2011 13:25:14 -0000 > From: =?utf-8?q?S=C3=83=C2=A9bastien_Vauban_=3Cwxhgmqzgwmuf=40spammotel=2Ec?= > =?utf-8?b?b20+?= > X-Patchwork-Id: 989 > Message-Id: <80lisogetx.fsf@somewhere.org> > To: emacs-orgmode@gnu.org > > Hi Carsten, > > > "Sebastien Vauban" wrote: > >> Carsten Dominik wrote: > >>>> I found it difficult, sometimes, to remember which subtree we're gonna > >>>> refile. When TAB'ing for multiple targets, you loose your source buffer, > >>>> and can easily forget which exact subtree you had selected. > >>>> > >>>> Here a patch to add the name of the subtree we're operating on. > >>> > >>> can you please resubmit a modified patch using either (org-get-heading t t) > >>> or (nth 4 (org-heading-components)) > >> > >> Thanks for looking at it. > >> > >> I'll do! > > > > Here it is: a modified version which only uses the text of the entry when > > asking where to refile some headline. > > Please disregard http://patchwork.newartisans.com/patch/987/ as it contained 2 > typos. > > This one is correct and can be applied straight away. > > Best regards, > Seb > > > >From e86292614425dd385af7857384853e8e6245462f Mon Sep 17 00:00:00 2001 > From: Sebastien Vauban > Date: Fri, 14 Oct 2011 09:18:55 +0200 > Subject: [PATCH] Use the text of the heading when refiling. > > --- > lisp/org.el | 22 ++++++++++++++-------- > 1 files changed, 14 insertions(+), 8 deletions(-) > > diff --git a/lisp/org.el b/lisp/org.el > index b26e1a3..66c2507 100644 > --- a/lisp/org.el > +++ b/lisp/org.el > @@ -10481,14 +10481,20 @@ prefix argument (`C-u C-u C-u C-c C-w')." > (marker-position org-clock-hd-marker))) > (setq goto nil))) > (setq it (or rfloc > - (save-excursion > - (unless goto (org-back-to-heading t)) > - (org-refile-get-location > - (cond (goto "Goto") > - (regionp "Refile region to") > - (t "Refile subtree to")) default-buffer > - org-refile-allow-creating-parent-nodes > - goto))))) > + (let (heading-text) > + (save-excursion > + (unless goto > + (org-back-to-heading t) > + (setq heading-text > + (nth 4 (org-heading-components)))) > + (org-refile-get-location > + (cond (goto "Goto") > + (regionp "Refile region to") > + (t (concat "Refile subtree \"" > + heading-text "\" to"))) > + default-buffer > + org-refile-allow-creating-parent-nodes > + goto)))))) > (setq file (nth 1 it) > re (nth 2 it) > pos (nth 3 it)) > -- > 1.7.5.1 > >