From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien Guerry <bzg@altern.org>
Subject: [Accepted]  icalendar: Make alarm duration RFC5545 compliant
Date: Thu, 25 Aug 2011 16:40:06 +0200 (CEST)
Message-ID: <20110825144006.7C0F06023@myhost.localdomain>
References: <1314282867-11165-1-git-send-email-sojka@os.inf.tu-dresden.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([140.186.70.92]:55919)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1Qwb5d-0001jz-5L
	for emacs-orgmode@gnu.org; Thu, 25 Aug 2011 10:39:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1Qwb5b-0004iy-HS
	for emacs-orgmode@gnu.org; Thu, 25 Aug 2011 10:39:29 -0400
Received: from mail-ww0-f41.google.com ([74.125.82.41]:34559)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1Qwb5b-0004is-3z
	for emacs-orgmode@gnu.org; Thu, 25 Aug 2011 10:39:27 -0400
Received: by wwj26 with SMTP id 26so5563633wwj.0
	for <emacs-orgmode@gnu.org>; Thu, 25 Aug 2011 07:39:25 -0700 (PDT)
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: </archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Patch 913 (http://patchwork.newartisans.com/patch/913/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C1314282867-11165-1-git-send-email-sojka%40os.inf.tu-dresden.de%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [O] icalendar: Make alarm duration RFC5545 compliant
> Date: Thu, 25 Aug 2011 19:34:27 -0000
> From: Michal Sojka <sojka@os.inf.tu-dresden.de>
> X-Patchwork-Id: 913
> Message-Id: <1314282867-11165-1-git-send-email-sojka@os.inf.tu-dresden.de>
> To: bzg@altern.org
> Cc: Michal Sojka <sojka@os.inf.tu-dresden.de>, cdominik@newartisans.com,
> 	emacs-orgmode@gnu.org
> 
> * org-icalendar.el (org-print-icalendar-entries): Make alarm duration
> RFC5545 compliant.
> 
> The format of alarm trigger was incorrect because "T" letter from
> dur-time element was missing (see
> http://tools.ietf.org/html/rfc5545#section-3.3.6). This caused some
> software (such as KOrganizer) to not interpret the alarms correctly.
> 
> TINYCHANGE
> 
> ---
> lisp/org-icalendar.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lisp/org-icalendar.el b/lisp/org-icalendar.el
> index bc0efce..a3ea88e 100644
> --- a/lisp/org-icalendar.el
> +++ b/lisp/org-icalendar.el
> @@ -419,7 +419,7 @@ When COMBINE is non nil, add the category to each line."
>  	  (let ((t1 (ignore-errors (org-parse-time-string ts 'nodefault))))
>  	    (if (and (> org-icalendar-alarm-time 0)
>  		     (car t1) (nth 1 t1) (nth 2 t1))
> -		(setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0D0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
> +		(setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0DT0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time))
>  	      (setq alarm ""))
>  	    )
>  	  (if (string-match org-bracket-link-regexp summary)
>