emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Change underscores to hyphens in section labels
@ 2011-05-18 19:58 Nick Dokos
  2011-05-24 11:12 ` [Accepted] " Carsten Dominik
  0 siblings, 1 reply; 2+ messages in thread
From: Nick Dokos @ 2011-05-18 19:58 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: nick

commit 5b6ac88c0c021f77d214d4fea37b305ab4928ebd
Author: Nick Dokos <nick@dokosmarshall.org>
Date:   Sun May 15 16:49:55 2011 -0400

    Change underscores to hyphens for labels

    * lisp/org-exp.el (org-export-define-heading-targets): Currently,
    the section number (a string of the form "X.Y.Z") is used to
    manufacture a section label of the form sec-X_Y_Z. Underscores are
    overloaded however, both in org and in LaTeX, and cause conflicts
    with some packages. This patch changes underscores to hyphens in
    section labels.

    TINYCHANGE

---
    Peter Frings reported a conflict with the ``syntax'' LaTeX
    package. Light testing (exporting simple files to LaTeX, by both
    Peter and myself, as well as exporting to ascii and HTML) has not
    uncovered any problems. I have not tested docbook, or Jambunathan
    K's odt exporter.

diff --git a/lisp/org-exp.el b/lisp/org-exp.el
index cda1f98..ac07c68 100644
--- a/lisp/org-exp.el
+++ b/lisp/org-exp.el
@@ -1298,7 +1298,7 @@ Also find all ID and CUSTOM_ID properties and store them."
 				       (org-outline-level))))
 	  (setq target (org-solidify-link-text
 			(format "sec-%s" (replace-regexp-in-string
-					  "\\." "_"
+					  "\\." "-"
 					  (org-section-number level)))))
 	  (setq last-section-target target)
 	  (push (cons target target) target-alist)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Accepted]  Change underscores to hyphens in section labels
  2011-05-18 19:58 [PATCH] Change underscores to hyphens in section labels Nick Dokos
@ 2011-05-24 11:12 ` Carsten Dominik
  0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2011-05-24 11:12 UTC (permalink / raw)
  To: emacs-orgmode

Patch 809 (http://patchwork.newartisans.com/patch/809/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C5905.1305748720%40alphaville.americas.hpqcorp.net%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [O] Change underscores to hyphens in section labels
> Date: Thu, 19 May 2011 00:58:40 -0000
> From: Nick Dokos <nick@dokosmarshall.org>
> X-Patchwork-Id: 809
> Message-Id: <5905.1305748720@alphaville.americas.hpqcorp.net>
> To: emacs-orgmode@gnu.org
> Cc: nick@dokosmarshall.org
> 
> commit 5b6ac88c0c021f77d214d4fea37b305ab4928ebd
> Author: Nick Dokos <nick@dokosmarshall.org>
> Date:   Sun May 15 16:49:55 2011 -0400
> 
>     Change underscores to hyphens for labels
> 
>     * lisp/org-exp.el (org-export-define-heading-targets): Currently,
>     the section number (a string of the form "X.Y.Z") is used to
>     manufacture a section label of the form sec-X_Y_Z. Underscores are
>     overloaded however, both in org and in LaTeX, and cause conflicts
>     with some packages. This patch changes underscores to hyphens in
>     section labels.
> 
>     TINYCHANGE
> 
> ---
> Peter Frings reported a conflict with the ``syntax'' LaTeX
>     package. Light testing (exporting simple files to LaTeX, by both
>     Peter and myself, as well as exporting to ascii and HTML) has not
>     uncovered any problems. I have not tested docbook, or Jambunathan
>     K's odt exporter.
> 
> diff --git a/lisp/org-exp.el b/lisp/org-exp.el
> index cda1f98..ac07c68 100644
> --- a/lisp/org-exp.el
> +++ b/lisp/org-exp.el
> @@ -1298,7 +1298,7 @@ Also find all ID and CUSTOM_ID properties and store them."
>  				       (org-outline-level))))
>  	  (setq target (org-solidify-link-text
>  			(format "sec-%s" (replace-regexp-in-string
> -					  "\\." "_"
> +					  "\\." "-"
>  					  (org-section-number level)))))
>  	  (setq last-section-target target)
>  	  (push (cons target target) target-alist)
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-24 11:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-18 19:58 [PATCH] Change underscores to hyphens in section labels Nick Dokos
2011-05-24 11:12 ` [Accepted] " Carsten Dominik

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).