emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <cdominik@newartisans.com>
To: emacs-orgmode@gnu.org
Subject: [Accepted]  Fix agenda display when headlines are missing
Date: Fri, 15 Apr 2011 13:55:09 +0200 (CEST)	[thread overview]
Message-ID: <20110415115509.BA049412BBE@u016822.science.uva.nl> (raw)
In-Reply-To: 1302696730-14326-1-git-send-email-bernt@norang.ca

Patch 748 (http://patchwork.newartisans.com/patch/748/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C1302696730-14326-1-git-send-email-bernt%40norang.ca%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [O] Fix agenda display when headlines are missing
> Date: Wed, 13 Apr 2011 17:12:10 -0000
> From: Bernt Hansen <bernt@norang.ca>
> X-Patchwork-Id: 748
> Message-Id: <1302696730-14326-1-git-send-email-bernt@norang.ca>
> To: emacs-orgmode@gnu.org
> Cc: Richard Riley <rileyrg@googlemail.com>, Bernt Hansen <bernt@norang.ca>
> 
> * lisp/org-agenda.el (org-agenda-get-timestamps): Fix agenda display when headlines are missing
> 
> The following entry breaks the agenda display.
> 
> ,----
> | ****
> |         :PROPERTIES:
> |         :DateCreated: <2011-04-13 Mi 10:00>
> |         :END:
> |
> | [[gnus:nntp%2BGwene:gwene.org.emacsen.planet][gnus:nntp+Gwene:gwene.org.emacsen.planet]]
> `----
> 
> Provide the empty string as the headline if the search for the
> headline returns nil.  org-format-agenda-items requires a string for
> the headline parameter.
> 
> ---
> Hi Richard,
> 
> This should if your issue.  Please test it and report back.
> This patch is available at git://git.norang.ca/org-mode.git fix-agenda-empty-headines
> 
> Regards,
> Bernt
> 
> 
>  lisp/org-agenda.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 5571838..768c417 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -4710,7 +4710,7 @@ This function is invoked if `org-agenda-todo-ignore-deadlines',
>  	    (setq hdmarker (org-agenda-new-marker)
>  		  tags (org-get-tags-at))
>  	    (looking-at "\\*+[ \t]+\\([^\r\n]+\\)")
> -	    (setq head (match-string 1))
> +	    (setq head (or (match-string 1) ""))
>  	    (setq txt (org-format-agenda-item
>  		       (if inactivep org-agenda-inactive-leader nil)
>  		       head category tags timestr
> 

      parent reply	other threads:[~2011-04-15 12:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-13  8:15 empty titles - backtrace Richard Riley
2011-04-13 12:12 ` [PATCH] Fix agenda display when headlines are missing Bernt Hansen
2011-04-13 12:22   ` Bernt Hansen
2011-04-15 11:55   ` Carsten Dominik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110415115509.BA049412BBE@u016822.science.uva.nl \
    --to=cdominik@newartisans.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).