From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien Guerry <bzg@altern.org>
Subject: [Accepted] Re: [PATCH] fix a bug in org-open-at-point
Date: Sat, 26 Feb 2011 18:14:57 +0100 (CET)
Message-ID: <20110226171457.245571E6E2@myhost.localdomain>
References: <8739nk1jmd.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=46827 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PtNjW-00008S-K1
	for emacs-orgmode@gnu.org; Sat, 26 Feb 2011 12:15:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1PtNjU-0002zh-GC
	for emacs-orgmode@gnu.org; Sat, 26 Feb 2011 12:15:06 -0500
Received: from mail-fx0-f41.google.com ([209.85.161.41]:49825)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1PtNjU-0002zA-Ax
	for emacs-orgmode@gnu.org; Sat, 26 Feb 2011 12:15:04 -0500
Received: by fxm5 with SMTP id 5so3107292fxm.0
	for <emacs-orgmode@gnu.org>; Sat, 26 Feb 2011 09:15:03 -0800 (PST)
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Patch 624 (http://patchwork.newartisans.com/patch/624/) is now "Accepted".

Maintainer comment: none

This relates to the following submission:

http://mid.gmane.org/%3C8739nk1jmd.fsf%40gmail.com%3E

Here is the original message containing the patch:

> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Re: [PATCH] fix a bug in org-open-at-point
> Date: Sat, 19 Feb 2011 14:03:38 -0000
> From: Nicolas Goaziou <n.goaziou@gmail.com>
> X-Patchwork-Id: 624
> Message-Id: <8739nk1jmd.fsf@gmail.com>
> To: emacs-orgmode@gnu.org
> 
> My bad, wrong manipulation. Here is the patch.
> 
> To reproduce the error, you can type the following in a fresh Org
> #+begin_src org
> target some text <<<target>>> another text target
> #+end_src
> 
> Using C-c C-o on any of the two links will return an error.
> Regards,
> 
> 
> >From f7738f3e9239fc4fddccc7850dad7a0936087a58 Mon Sep 17 00:00:00 2001
> From: Nicolas Goaziou <n.goaziou@gmail.com>
> Date: Sat, 19 Feb 2011 09:37:48 +0100
> Subject: [PATCH] Fix bug with link to radio target at beginning or end of buffer
> 
> * lisp/org.el (org-open-at-point): if a link to a radio target is the
>   first, (resp. the last), element of a buffer, function cannot find
>   the property change required to get its boundaries, and
>   `buffer-substring' is called with an invalid nil argument.
> ---
>  lisp/org.el |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/lisp/org.el b/lisp/org.el
> index b92186a..bfe9296 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -9214,8 +9214,10 @@ application the system uses for this file type."
>  		pos (if (get-text-property (1+ (point)) 'org-linked-text)
>  			(1+ (point)) (point))
>  		path (buffer-substring
> -		      (previous-single-property-change pos 'org-linked-text)
> -		      (next-single-property-change pos 'org-linked-text)))
> +		      (or (previous-single-property-change pos 'org-linked-text)
> +			  (point-min))
> +		      (or (next-single-property-change pos 'org-linked-text)
> +			  (point-max))))
>  	  (throw 'match t))
>  
>  	(save-excursion
> -- 
> 1.7.4.1
> 
>