From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Guerry Subject: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)] Date: Tue, 1 Feb 2011 12:52:10 +0100 (CET) Message-ID: <20110201115210.6AD9A8783@myhost.localdomain> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=57181 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PkEmJ-0001vI-7C for emacs-orgmode@gnu.org; Tue, 01 Feb 2011 06:52:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PkEmH-0001V7-HN for emacs-orgmode@gnu.org; Tue, 01 Feb 2011 06:52:11 -0500 Received: from mail-fx0-f41.google.com ([209.85.161.41]:45103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PkEmH-0001Uu-Cs for emacs-orgmode@gnu.org; Tue, 01 Feb 2011 06:52:09 -0500 Received: by fxm12 with SMTP id 12so7638885fxm.0 for ; Tue, 01 Feb 2011 03:52:08 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Patch 543 (http://patchwork.newartisans.com/patch/543/) is now "Accepted". Maintainer comment: none This relates to the following submission: http://mid.gmane.org/%3Csa3ei8b1sbv.fsf%40cigue.easter-eggs.fr%3E Here is the original message containing the patch: > Content-Type: text/plain; charset="utf-8" > MIME-Version: 1.0 > Content-Transfer-Encoding: 7bit > Subject: [Orgmode] Re: Bug: Jumping to a date in the agenda changes view back > to 'day' [7.4 (release_7.4.80.g0e5e5)] > Date: Mon, 17 Jan 2011 20:08:04 -0000 > From: Julien Danjou > X-Patchwork-Id: 543 > Message-Id: > To: Carsten Dominik > Cc: Bernt Hansen , Org Mode , > Noorul Islam K M > > On Mon, Jan 17 2011, Carsten Dominik wrote: > > > have you been following this thread? I think this has to do with your > > rewrite of the dagenda span stuff. Maybe you can find out better and > > faster that I why this goes wrong? Please read the entire thread. > > I've followed but not sure I understood what the bug is. But from my > various tries, I found a bug: when pressing 'j', the current span is > discarded. > > Attached is a patch that should fix that, even for future use of > `org-agenda-list' with the span unspecified. :) > > > >From 9dd2fe6650b858a4083ebc083bb8d10a0d6ac7f2 Mon Sep 17 00:00:00 2001 > From: Julien Danjou > Date: Mon, 17 Jan 2011 16:05:28 +0100 > Subject: [PATCH] Fix agenda span on date jump > > * org-agenda.el (org-agenda-list): Use org-agenda-current-span as a > possible default span if it is set. > > Signed-off-by: Julien Danjou > --- > lisp/org-agenda.el | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el > index 0cd620c..0d695b5 100644 > --- a/lisp/org-agenda.el > +++ b/lisp/org-agenda.el > @@ -3450,7 +3450,10 @@ given in `org-agenda-start-on-weekday'." > (setq org-agenda-last-arguments (list include-all start-day span)) > (org-compile-prefix-format 'agenda) > (org-set-sorting-strategy 'agenda) > - (let* ((span (org-agenda-ndays-to-span (or span org-agenda-ndays org-agenda-span))) > + (let* ((span (org-agenda-ndays-to-span (or span > + org-agenda-current-span > + org-agenda-ndays > + org-agenda-span))) > (today (org-today)) > (sd (or start-day today)) > (ndays (org-agenda-span-to-ndays span sd)) > -- > 1.7.2.3 > >