From: Joost Helberg <joost@snow.nl>
To: carsten.dominik@gmail.com
Cc: emacs-orgmode@gnu.org
Subject: Re: error in calculating percentages in clocktables
Date: Fri, 03 Dec 2010 11:13:28 +0100 (CET) [thread overview]
Message-ID: <20101203.111328.221844449.joost@snow.nl> (raw)
In-Reply-To: <3F1F7C35-B348-4A8A-9F1E-91E7D78B5092@gmail.com>
Carsten,
your more general approach works fine for me. The pushed fix seems
allright.
many regards,
Joost
>>>>> "Carsten" == Carsten Dominik <carsten.dominik@gmail.com> writes:
> Subject: Re: [Orgmode] error in calculating percentages in clocktables
> From: Carsten Dominik <carsten.dominik@gmail.com>
> To: Joost Helberg <joost@snow.nl>
> Cc: emacs-orgmode@gnu.org
> Date: Fri, 3 Dec 2010 09:52:57 +0100
> Hi Joost,
> thanks for this, but the new tables are complex and the patch was not
> general enough. I have just pushed a fix which I think is correct.
> Please verify.
> - Carsten
> On Nov 29, 2010, at 11:56 AM, Joost Helberg wrote:
>> ls,
>>
>> I'm using clocktables and encountered an issue in calculating the
>> percentage in the last column. Some columns have moved 1 left in the
>> head-revision, but the generated formula was not changed.
>> Hence the following patch. The percentages come out OK with this
>> patch.
>>
>> Can someone using clocktables verify that this patch is correct and
>> doesn't break other stuff?
>>
>> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
>> index eb859df..0c7c73b 100644
>> --- a/lisp/org-clock.el
>> +++ b/lisp/org-clock.el
>> @@ -2173,9 +2173,9 @@ from the dynamic block defintion."
>> (format
>> "\n#+TBLFM: $%d='(org-clock-time%% @%d$%d $%d..$%d);%%.1f"
>> pcol
>> - (+ 2 (if narrow 1 0))
>> - (+ 3 (if multifile 1 0))
>> - (+ (if multifile 1 0) 3)
>> + (+ 1 (if narrow 1 0))
>> + (+ 2 (if multifile 1 0))
>> + (+ (if multifile 1 0) 2)
>> (1- pcol)))
>> (setq recalc t))
>> ((stringp formula)
>>
>> regards,
>>
>> Joost Helberg
>>
>> --
>> Snow B.V. http://snow.nl
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Please use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
> - Carsten
--
Snow B.V. http://snow.nl
next prev parent reply other threads:[~2010-12-03 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 10:56 error in calculating percentages in clocktables Joost Helberg
2010-12-03 8:52 ` Carsten Dominik
2010-12-03 10:13 ` Joost Helberg [this message]
2010-12-03 10:37 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101203.111328.221844449.joost@snow.nl \
--to=joost@snow.nl \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).