From: Carsten Dominik <cdominik@newartisans.com>
To: emacs-orgmode@gnu.org
Subject: [Accepted] Explicitly mention when a language-mode throws an error
Date: Tue, 14 Sep 2010 14:03:34 +0200 (CEST) [thread overview]
Message-ID: <20100914120335.02D477588A8@u016822.science.uva.nl> (raw)
In-Reply-To: 87sk1luntu.fsf@gmail.com
Patch 263 (http://patchwork.newartisans.com/patch/263/) is now "Accepted".
Maintainer comment: none
This relates to the following submission:
http://mid.gmane.org/%3C87sk1luntu.fsf%40gmail.com%3E
Here is the original message containing the patch:
> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Explicitly mention when a language-mode throws an error
> Date: Wed, 08 Sep 2010 04:38:05 -0000
> From: Eric Schulte <schulte.eric@gmail.com>
> X-Patchwork-Id: 263
> Message-Id: <87sk1luntu.fsf@gmail.com>
> To: Org Mode <emacs-orgmode@gnu.org>
>
> Hi,
>
> The attached patch makes it clear when a language mode has thrown an
> error. This can clear up confusion whether an error is originating from
> Org-mode or form the language-mode in question.
>
> Should this be committed?
>
> Best -- Eric
>
>
> diff --git a/lisp/org-src.el b/lisp/org-src.el
> index d1948cc..233058a 100644
> --- a/lisp/org-src.el
> +++ b/lisp/org-src.el
> @@ -276,7 +276,10 @@ buffer."
> (unless preserve-indentation
> (setq total-nindent (or (org-do-remove-indentation) 0)))
> (let ((org-inhibit-startup t))
> - (funcall lang-f))
> + (condition-case e
> + (funcall lang-f)
> + (error
> + (error "Language mode `%s' fails with: %S" lang-f (nth 1 e)))))
> (set (make-local-variable 'org-edit-src-force-single-line) single)
> (set (make-local-variable 'org-edit-src-from-org-mode) org-mode-p)
> (set (make-local-variable 'org-edit-src-allow-write-back-p) allow-write-back-p)
>
prev parent reply other threads:[~2010-09-14 12:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 23:38 Explicitly mention when a language-mode throws an error Eric Schulte
2010-09-14 12:03 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914120335.02D477588A8@u016822.science.uva.nl \
--to=cdominik@newartisans.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).