From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juan Subject: Re: Re: [BABEL] Output with octave + [PATCH] x2 Date: Sun, 1 Aug 2010 17:07:27 -0300 Message-ID: <20100801200727.GT5569@soloJazz.com> References: <87iq45x06e.wl%ucecesf@ucl.ac.uk> <871vai42nz.fsf@stats.ox.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=45106 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ofeop-0006lr-Fs for emacs-orgmode@gnu.org; Sun, 01 Aug 2010 16:07:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ofeon-0004wK-Tm for emacs-orgmode@gnu.org; Sun, 01 Aug 2010 16:07:35 -0400 Received: from cpoproxy2-pub.bluehost.com ([67.222.39.38]:53938) by eggs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1Ofeon-0004vv-K2 for emacs-orgmode@gnu.org; Sun, 01 Aug 2010 16:07:33 -0400 Content-Disposition: inline In-Reply-To: <871vai42nz.fsf@stats.ox.ac.uk> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Dan Davison Cc: emacs-orgmode@gnu.org, "d.tchin" Hi, I'm starting to work with ob-octave and found several problems: The first, for which I have a fix (see patch below) is that octave's output was passed on as a string instead of being interpreted as a table: 8<------------------------------------------------------------ diff --git a/lisp/ob-octave.el b/lisp/ob-octave.el index 8e99f86..d0d16fe 100644 --- a/lisp/ob-octave.el +++ b/lisp/ob-octave.el @@ -181,7 +181,7 @@ value of the last statement in BODY, as elisp." (org-babel-eval cmd (format org-babel-octave-wrapper-method body tmp-file tmp-file)) - (org-babel-eval-read-file tmp-file)))))) + (org-babel-octave-import-elisp-from-file tmp-file)))))) (defun org-babel-octave-evaluate-session (session body result-type &optional matlabp) 8<------------------------------------------------------------ Now this works: 8<------------------------------------------------------------ #+source: test_output #+begin_src octave :results value vector [[1 2 3];[4 5 6]] #+end_src #+results: test_output | 1.00000000e+00 | 2.00000000e+00 | 3.00000000e+00 | | 4.00000000e+00 | 5.00000000e+00 | 6.00000000e+00 | 8<------------------------------------------------------------ (before the patch you'd get a single table element with something like "1 2 3\n 4 5 6\n" inside). The second problem is that if I use octave table output as input to another block, it gets interpreted as a string instead of a vector: 8<------------------------------------------------------------ #+results: test_output | 1.25000000e+00 | #+source: check_input #+begin_src octave :var input=test_output() :results output ischar( input ) size( input ) #+end_src #+results: check_input : input = 1.25000000e+00 : ans = 1 : ans = : 1 14 8<------------------------------------------------------------ This has to do with the EXP notation. The 'e+00' suffix makes the whole table into a string. The problem is with "%S" in the formatting inside org-babel-octave-var-to-octave. The following patch seems to fix it (and makes it possible to work with complex numbers inside the tables):: 8<------------------------------------------------------------ diff --git a/lisp/ob-octave.el b/lisp/ob-octave.el index 8e99f86..4329c7f 100644 --- a/lisp/ob-octave.el +++ b/lisp/ob-octave.el @@ -120,7 +120,7 @@ Converts an emacs-lisp variable into a string of octave code specifying a variable of the same value." (if (listp var) (concat "[" (mapconcat #'org-babel-octave-var-to-octave var ", ") "]") - (format "%S" var))) + (format "%s" var))) (defun org-babel-prep-session:octave (session params &optional matlabp) "Prepare SESSION according to the header arguments specified in PARAMS." 8<------------------------------------------------------------ A third problem is with org-babel-octave-var-to-octave. For example: : (org-babel-octave-var-to-octave '( ( 1 2 3 ) ( 4 5 6 ) )) : -> "[[1, 2, 3], [4, 5, 6]]" This is not a 2x3 matrix, but a 1x6 vector: : octave-3.2.3:1> [[1,2,3],[4,5,6]] : ans = : 1 2 3 4 5 6 a semicolon ';' or '\n' is needed between rows instead of a comma. To sum up: - 2 patches for prepare-session and importing the results back as org-tables (I don't know if these patches break anything). - 1 problem with matrix notation in org-babel-octave-var-to-octave. I'll try to provide a patch for this today. I'm not working with sessions, so I have not yet tested the original problem reported with 'org_babel_eoe' showing up as result. Regards, .j. On Sun, Aug 01, 2010 at 02:18:40PM -0400, Dan Davison wrote: > Eric S Fraga writes: > > On Fri, 23 Jul 2010 16:59:43 +0000 (UTC), d.tchin wrote: > >> I have problem to get output back in org mode file.