From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viktor Rosenfeld Subject: Re: [PATCH] Fix clocking on capture completion Date: Sat, 24 Jul 2010 20:41:51 +0200 Message-ID: <20100724184151.GA97728@stan> References: <1279981217-14625-1-git-send-email-bernt@norang.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=55151 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ocjnc-0001ZA-7m for emacs-orgmode@gnu.org; Sat, 24 Jul 2010 14:50:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ocjnb-0002jv-59 for emacs-orgmode@gnu.org; Sat, 24 Jul 2010 14:50:16 -0400 Received: from mail-bw0-f41.google.com ([209.85.214.41]:43297) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ocjna-0002jp-TH for emacs-orgmode@gnu.org; Sat, 24 Jul 2010 14:50:15 -0400 Received: by bwz9 with SMTP id 9so2620363bwz.0 for ; Sat, 24 Jul 2010 11:50:13 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1279981217-14625-1-git-send-email-bernt@norang.ca> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen Cc: emacs-orgmode@gnu.org Hi, this patch fixes the problem for me. I'm on release_7.01g.24.g6b5cf.dirty A somewhat related question: I use your bh/clock-in-to-next function to change the todo state to STARTED when clocking in TODO tasks. Unfortunately it is being applied to Capture buffers. I tried changing the buffer-name to "CAPTURE-*" but that didn't help. Thanks, Viktor Bernt Hansen wrote: > * lisp/org-capture.el (org-capture-finalize): Fix clock in of interrupted > task during capture finalize > > Calling org-capture-get inside the org-with-point-at macro does not > work when the current clocking task and the capture target buffer are > the same. In this case the captured task would continue clocking > instead of switching back to the previously clocking task. > --- > I think this patch fixes the issue but it should receive more testing. > Please report back if this works or not. > > -Bernt > > > lisp/org-capture.el | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lisp/org-capture.el b/lisp/org-capture.el > index cf09dce..2efed78 100644 > --- a/lisp/org-capture.el > +++ b/lisp/org-capture.el > @@ -467,8 +467,9 @@ bypassed." > (markerp (org-capture-get :interrupted-clock 'local)) > (buffer-live-p (marker-buffer > (org-capture-get :interrupted-clock 'local)))) > - (org-with-point-at (org-capture-get :interrupted-clock 'local) > - (org-clock-in)) > + (let ((clock-in-task (org-capture-get :interrupted-clock 'local))) > + (org-with-point-at clock-in-task > + (org-clock-in))) > (message "Interrupted clock has been resumed"))) > > (let ((beg (point-min)) > -- > 1.7.2 > > > _______________________________________________ > Emacs-orgmode mailing list > Please use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode