From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Holcomb Subject: PATCH Bugfix: bulk mark/unmark selects wrong next item when restricted Date: Sat, 2 Jan 2010 15:45:25 -0600 Message-ID: <20100102214525.GN6266@cpoint.net> Reply-To: pholcomb@cpoint.net Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="8P1HSweYDcXXzwPJ" Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NRBuX-0001un-8n for emacs-orgmode@gnu.org; Sat, 02 Jan 2010 16:53:25 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NRBuS-0001sQ-R5 for emacs-orgmode@gnu.org; Sat, 02 Jan 2010 16:53:25 -0500 Received: from [199.232.76.173] (port=36046 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRBuS-0001sN-J8 for emacs-orgmode@gnu.org; Sat, 02 Jan 2010 16:53:20 -0500 Received: from mailhost.cpoint.net ([204.10.55.14]:45540) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1NRBuS-0008TN-8k for emacs-orgmode@gnu.org; Sat, 02 Jan 2010 16:53:20 -0500 Content-Disposition: inline List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Org Mode --8P1HSweYDcXXzwPJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline When you are in agenda view and limit the items that are visible, such as with a tag restriction, marking and unmarking behaves incorrectly. After the item is marked or unmarked for bulk action, the point is moved to the next item, regardless of whether the next item is visible. -- Paul Holcomb *pholcomb \@ cpoint net* GPG key fingerprint 2B62 05AE EE74 845A 705F D716 28C4 FE1C 088F CFAC --8P1HSweYDcXXzwPJ Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="org-agenda.el-bulkmark.patch" 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index da60310..670b4b0 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -7057,7 +7057,7 @@ This is a command that has to be installed in `calendar-mode-map'." (org-get-todo-face "TODO") 'evaporate) (org-overlay-put ov 'type 'org-marked-entry-overlay)) - (beginning-of-line 2) + (org-agenda-next-line) (message "%d entries marked for bulk action" (length org-agenda-bulk-marked-entries)))) @@ -7070,8 +7070,8 @@ This is a command that has to be installed in `calendar-mode-map'." (setq org-agenda-bulk-marked-entries (delete (org-get-at-bol 'org-hd-marker) org-agenda-bulk-marked-entries))) - (beginning-of-line 2) - (message "%d entries marked for bulk action" + (org-agenda-next-line) +(message "%d entries marked for bulk action" (length org-agenda-bulk-marked-entries))) (defun org-agenda-bulk-toggle () --8P1HSweYDcXXzwPJ Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --8P1HSweYDcXXzwPJ--