From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Spiers Subject: Re: Re: org-show-effort ideas Date: Wed, 4 Nov 2009 00:26:08 +0000 Message-ID: <20091104002608.GH32187@atlantic.linksys.moosehall> References: <20091102134924.GC25581@atlantic.linksys.moosehall> <20091103121138.GF32187@atlantic.linksys.moosehall> <87aaz37jqz.fsf@in-ulm.de> Reply-To: Adam Spiers Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N5ThZ-00015T-Ho for emacs-orgmode@gnu.org; Tue, 03 Nov 2009 19:26:17 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N5ThU-00012K-GD for emacs-orgmode@gnu.org; Tue, 03 Nov 2009 19:26:16 -0500 Received: from [199.232.76.173] (port=47542 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N5ThU-00012H-DZ for emacs-orgmode@gnu.org; Tue, 03 Nov 2009 19:26:12 -0500 Received: from arctic.adamspiers.org ([212.13.194.176]:33076) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N5ThU-0006In-6x for emacs-orgmode@gnu.org; Tue, 03 Nov 2009 19:26:12 -0500 Received: from localhost (dsl-217-155-199-114.zen.co.uk [217.155.199.114]) by arctic.adamspiers.org (Postfix) with ESMTP id 2F33624A29 for ; Wed, 4 Nov 2009 00:26:10 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87aaz37jqz.fsf@in-ulm.de> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Benjamin Andresen (benny@in-ulm.de) wrote: > Adam Spiers writes: > > > I definitely did try it, and I just did another 'git pull' and tried > > again, and I still don't see it, so I guess we're talking about > > different things ;-) > > > > To clarify, I'm referring to showing effort via a single keystroke > > when on a todo line in the *Org Agenda* buffer. Currently, when I hit > > "e" on a todo which has an existing "Effort" property value set, my > > minibuffer prompt shows "Value: ". The same applies with C-c C-x e in > > a normal .org file buffer. > > When I press 'e' in an agenda on an item that has the Effort property > value set, I get a minibuffer prompt that shows "Value [5]: " when the > Effort value is 5. > > This is with a git version from Sunday morning. > > Check the source of the function org-set-effort, it will show you that > it concats "[" cur "]", where cur is the current Effort prop value. Thanks for the pointer - it seems that the "[" cur "]" is only included when (org-property-get-allowed-values nil prop 'table) is nil - and in my case I have a global Effort_ALL property set which means that this is never the case. So I think this is a bug which can be trivially fixed by assigning the prompt string in the let* variable list, and then using it in both invocations of org-completing-read.