From: Mario Frasca <firstname.lastname@example.org>
Subject: Re: [PATCH] may we focus on readability?
Date: Mon, 15 Jun 2020 09:49:06 -0500 [thread overview]
Message-ID: <email@example.com> (raw)
Hi Nicolas, I think that the hint on testing is very correct, I'm afraid
I changed the semantics of one of the original tests, and I found that
there's other cl functions other than just cl-some, also cl-every,
cl-notevery, and cl-notany. I'll have a closer look at this. and write
some tests before changing the code.
I also looked for the strange idiom used here, and these two are the
only two locations I found.
how do I run tests from the command line (I'm using make test) but then
limited to one lisp file? or one specific test?
On 14/06/2020 14:32, Nicolas Goaziou wrote:
> Also, further nit: (not (cl-every ...)) will apply `not' only once.
> In any case, it would be better if refactoring happens while introducing
> unit tests *hint*.
next prev parent reply other threads:[~2020-06-15 14:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 16:47 Mario Frasca
2020-06-14 17:24 ` tomas
2020-06-14 19:28 ` Nicolas Goaziou
2020-06-14 19:30 ` tomas
2020-06-14 19:32 ` Nicolas Goaziou
2020-06-15 14:49 ` Mario Frasca [this message]
2020-06-15 20:52 ` Mario Frasca
2020-06-16 16:56 ` Nicolas Goaziou
2020-06-16 17:26 ` Mario Frasca
2020-06-28 6:47 ` Nicolas Goaziou
2020-06-28 6:46 ` Nicolas Goaziou
2020-06-16 15:29 ` Nicolas Goaziou
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).