From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: minor bug: org-remember without target file buffer causes error Date: Sun, 21 Sep 2008 08:38:18 +0200 Message-ID: <1ABED850-1E39-4EED-897E-3B5CF2973E88@uva.nl> References: <20524da70809202142pa83a637na9a140a20faaa9c1@mail.gmail.com> Mime-Version: 1.0 (Apple Message framework v929.2) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KhIaW-0005Yk-MC for emacs-orgmode@gnu.org; Sun, 21 Sep 2008 02:38:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KhIaU-0005YY-4j for emacs-orgmode@gnu.org; Sun, 21 Sep 2008 02:38:31 -0400 Received: from [199.232.76.173] (port=42817 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KhIaT-0005YV-WC for emacs-orgmode@gnu.org; Sun, 21 Sep 2008 02:38:30 -0400 Received: from mx20.gnu.org ([199.232.41.8]:49120) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KhIaT-0003A5-GA for emacs-orgmode@gnu.org; Sun, 21 Sep 2008 02:38:29 -0400 Received: from pony.ic.uva.nl ([145.18.40.181]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KhIaS-0003OP-G3 for emacs-orgmode@gnu.org; Sun, 21 Sep 2008 02:38:28 -0400 In-Reply-To: <20524da70809202142pa83a637na9a140a20faaa9c1@mail.gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Samuel Wales Cc: emacs-orgmode@gnu.org Hi Samuel, I cannot reproduce this bug. Please try again with 6.07b, and if it persists, make me a test case with configuration. Thanks. - Carsten P.S. Yes, org-remember-handler is a monster....... On Sep 21, 2008, at 6:42 AM, Samuel Wales wrote: > In org-mode 6.06b, c-c c-c after org-remember without first finding > the target file causes wrong type argument stringp, nil error. Trying > it again works OK. > This is not a problem for me. > > Perhaps the relevant function, org-remember-handler, can be broken > into smaller functions for easier debugging. > > Thanks. > > > set-buffer(nil) > (save-current-buffer (set-buffer (or visiting ...)) (unless > (org-mode-p) (error "Target files for remember notes must be in > Org-mode")) (save-excursion (save-restriction ... ... ... ... ... ... > ... ... ... ...))) > (with-current-buffer (or visiting (get-file-buffer file)) (unless > (org-mode-p) (error "Target files for remember notes must be in > Org-mode")) (save-excursion (save-restriction ... ... ... ... ... ... > ... ... ... ...))) > (let* ((visitp ...) (fastp ...) (file ...) (heading > org-remember-default-headline) (visiting ...) (org-startup-folded nil) > (org-startup-align-all-tables nil) (org-goto-start-pos 1) spos exitcmd > level reversed txt) (if (and ... org-remember-previous-location) (setq > file ... heading ... fastp t)) (setq current-prefix-arg nil) > (goto-char (point-min)) (if (re-search-forward "[ > ]+\\'" nil t) (replace-match "")) (goto-char (point-min)) (unless > (looking-at org-outline-regexp) (insert ...) (backward-char 1) (when > org-adapt-indentation ...)) (goto-char (point-min)) (if > (re-search-forward " > [ ]* > [ > ]*\\'" nil t) (replace-match " > > ") (if ... ...)) (goto-char (point-min)) (setq txt (buffer-string)) > (org-save-markers-in-region (point-min) (point-max)) (when (and ... > ...) (org-refile nil ...) (and visitp ...) (throw ... t)) (if (not > visiting) (find-file-noselect file)) (with-current-buffer (or visiting > ...) (unless ... ...) (save-excursion ...))) > (catch (quote quit) (if org-note-abort (throw ... nil)) (let* (... > ... ... ... ... ... ... ... spos exitcmd level reversed txt) (if ... > ...) (setq current-prefix-arg nil) (goto-char ...) (if ... ...) > (goto-char ...) (unless ... ... ... ...) (goto-char ...) (if ... ... > ...) (goto-char ...) (setq txt ...) (org-save-markers-in-region ... > ...) (when ... ... ... ...) (if ... ...) (with-current-buffer ... ... > ...))) > org-remember-handler() > run-hook-with-args-until-success(org-remember-handler) > (if remember-all-handler-functions (run-hooks (quote > remember-handler-functions)) (run-hook-with-args-until-success (quote > remember-handler-functions))) > (save-restriction (narrow-to-region b e) (if > remember-all-handler-functions (run-hooks ...) > (run-hook-with-args-until-success ...)) (remember-destroy)) > (let ((b ...) (e ...)) (save-restriction (narrow-to-region b e) (if > remember-all-handler-functions ... ...) (remember-destroy))) > remember-region(1 409) > remember-finalize() > org-remember-finalize() > funcall(org-remember-finalize) > (cond ((or ... org-occur-highlights > org-latex-fragment-image-overlays) (and ... ...) > (org-remove-occur-highlights) > (org-remove-latex-fragment-image-overlays) (message "Temporary > highlights/overlays removed from current buffer")) ((and ... ...) > (funcall org-finish-function)) ((org-at-property-p) > (call-interactively ...)) ((org-on-target-p) (call-interactively ...)) > ((org-on-heading-p) (call-interactively ...)) ((org-at-table\.el-p) > (require ...) (beginning-of-line 1) (re-search-forward "|" ...) > (call-interactively ...)) ((org-at-table-p) > (org-table-maybe-eval-formula) (if arg ... ...) (call-interactively > ...)) ((org-at-item-checkbox-p) (call-interactively ...)) > ((org-at-item-p) (call-interactively ...)) ((save-excursion ... ...) > (beginning-of-line 1) (org-update-dblock)) ((save-excursion ... ...) > (cond ... ...)) (t (error "C-c C-c can do nothing useful at this > location."))) > (let ((org-enable-table-editor t)) (cond (... ... ... ... ...) (... > ...) (... ...) (... ...) (... ...) (... ... ... ... ...) (... ... ... > ...) (... ...) (... ...) (... ... ...) (... ...) (t ...))) > org-ctrl-c-ctrl-c(nil) > call-interactively(org-ctrl-c-ctrl-c) > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode