From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: Replacement for org-make-link Date: Mon, 20 Aug 2012 13:23:25 -0400 Message-ID: <19707.1345483405@alphaville> References: <2012-08-20T18-59-49@devnull.Karl-Voit.at> Reply-To: nicholas.dokos@hp.com Return-path: Received: from eggs.gnu.org ([208.118.235.92]:59673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3VhL-00024k-Ml for emacs-orgmode@gnu.org; Mon, 20 Aug 2012 13:23:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3VhJ-0001ly-U8 for emacs-orgmode@gnu.org; Mon, 20 Aug 2012 13:23:31 -0400 Received: from g4t0015.houston.hp.com ([15.201.24.18]:8676) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3VhJ-0001lt-OF for emacs-orgmode@gnu.org; Mon, 20 Aug 2012 13:23:29 -0400 In-Reply-To: Message from Karl Voit of "Mon, 20 Aug 2012 19:03:38 +0200." <2012-08-20T18-59-49@devnull.Karl-Voit.at> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: news1142@Karl-Voit.at Cc: emacs-orgmode@gnu.org Karl Voit wrote: > Hi! > > http://orgmode.org/Changes.html tells me that org-make-link has been > deleted. > > I am using following lines to add links to references I manage using > Org-mode: (from [1]) > > ,---- > | (defun org-ref-complete-link (&optional arg) > | "Create a reference link using completion." > | (let (file link) > | (setq file (read-file-name "ref: " "~/archive/papers_from_web/")) > | (let ((pwd (file-name-as-directory (expand-file-name "."))) > | (pwd1 (file-name-as-directory (abbreviate-file-name > | (expand-file-name "."))))) > | (setq file (string-replace "~/archive/papers_from_web/" "" file)) > | (setq file (string-replace pwd "" (string-replace pwd1 "" file))) > | (setq file (string-replace ".bib" "" file)) > | (setq file (string-replace ".pdf" "" file)) > | (setq link (org-make-link "ref:" file))) > | link)) > `---- > > Can somebody with more knowledge than me suggest, what I should do > instead? > Replace it with concat, I think. That's all that org-make-link used to do: ,---- | (defun org-make-link (&rest strings) | "Concatenate STRINGS." | (apply 'concat strings)) `---- In fact the commit says: ,---- | commit 96551f3dd8885dee6972c70ce06888fd3d5f4dd4 | Author: Bastien Guerry | Date: Fri Aug 3 19:03:21 2012 +0200 | | Delete `org-make-link' and replace previous occurrences by `concat'. `---- Nick