From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 2MAUILmy9mUIBgAAe85BDQ:P1 (envelope-from ) for ; Sun, 17 Mar 2024 10:07:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 2MAUILmy9mUIBgAAe85BDQ (envelope-from ) for ; Sun, 17 Mar 2024 10:07:05 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=excalamus.com header.s=zmail header.b=eo+8r4qE; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1710666425; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=7lIPbrlUdX9ayFhwMS3aNz/wjoJWqwIEQOIbY1fUlhc=; b=urUC+h3hWf5aD0g8jxtl7eNJnoUZpdObugMLD3S995C5vV6+FqavneiFikOvq71VNq4fFa n6u0o3DwOUikbADbMX6W9rIZ8CyxQP6qu/vZWogzCucqZ8LI4780C6iv2cJHEaOA6JxCso nBF/K8u2M77rydv7lqNzaLENgpdIjk7BdWPC7EjrqaO99DjKZYQTEwgG0egLT6lDrO6Gk/ PCh3qygi9XBHftODnAHADghKDYYn0RCV7EjosI31A5nsQr7Ju3kW74V540Of4PKXuNst+9 IjrBT/TAewTyjXigW2nZxEFtWJ7hBFX6xp+QOf1tvrWBVFeMPBRdPN9g8UHApA== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1710666425; a=rsa-sha256; cv=pass; b=XnoWXHBb60FbKZ+37SMRg39HIrLYpEeKj0FA7RY5L2oVRobUMzQJjttRMycY3on43aMjQU EL1rnggKp0nOOhKLFOq5JlbSalk+Gr/r7/9jWTcKsv7AyNaEZnG+y2Eu/zS5FTuBEib1KZ 6CETFkol+7i5db+m77mJCbvft24jCLAZf7Vm62F0q1AdZPRVuIlUMtPaCgqxdTCisppqR+ KOnEaZ6s+MCd5RvVoLBYb7aPxxBfkmFXQzxSH7OCmgMmUWfHuOFnSkQNeF8UqzNIAqX6Oy U6wszuvXckrG6dO566X5mSu8hlcWJ9zVSYWLF8gHqhDp1f/jY+z7kSbPiPuP/g== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=excalamus.com header.s=zmail header.b=eo+8r4qE; arc=pass ("zohomail.com:s=zohoarc:i=1"); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 04F4C75A6E for ; Sun, 17 Mar 2024 10:07:05 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlmTE-0003oQ-Fl; Sun, 17 Mar 2024 05:06:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlmTC-0003oH-Ho for emacs-orgmode@gnu.org; Sun, 17 Mar 2024 05:06:18 -0400 Received: from sender4-pp-f112.zoho.com ([136.143.188.112]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlmTA-0003lR-Bz for emacs-orgmode@gnu.org; Sun, 17 Mar 2024 05:06:18 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1710666369; cv=none; d=zohomail.com; s=zohoarc; b=Su5AClFfE7d9mNl/tyypVjm6oL52aYMM4XPGq/y5T0BIMo7Hbw1SWfc6PuOOwPH6MEkmhi2gsgXSIDmTEL+BuLOWtWJ6tYp+hcwAuY8GiOdrL7JqUTT3d0Uev5MxABD2C+341jPyFRmjA0WzLCxpCLvhlBK9Xr7D5kJQ6cgXNGk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710666369; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=7lIPbrlUdX9ayFhwMS3aNz/wjoJWqwIEQOIbY1fUlhc=; b=ezqewz6B+Zjbw3QMOfTfJdzUXuZC6c0Y/LhlK5R7yWgWL7aGWTWWi1YCQQme51US47U90jy92aBdUVudvXo/CTr9xYIlGvySorhTfnj4TpgJyR+eosVbYrh1EVEwqA44mbUQ5Nf5MOJkdgVtCgCkfyGzqnwr7qzmTpzJAVaIpzQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=excalamus.com; spf=pass smtp.mailfrom=matt@excalamus.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1710666369; s=zmail; d=excalamus.com; i=matt@excalamus.com; h=Date:Date:From:From:To:To:Cc:Cc:Message-ID:In-Reply-To:References:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=7lIPbrlUdX9ayFhwMS3aNz/wjoJWqwIEQOIbY1fUlhc=; b=eo+8r4qELYBmUTcgoYKDuJa7KsNAb8+LE9jNmirtsys8/NYqGiz8vOPmL1RgnRgk SX8/CcRbLl+d+U6omclrM8HuMTobJG53CRGHyZhKkXYJ0wRynr8zLLTPMEvwL+/0I8Y 1GGmR/EqYyCqWVy/iVo4dn5pL3oLWxQv1KW7QCMg= Received: from mail.zoho.com by mx.zohomail.com with SMTP id 1710666368219986.6545541326317; Sun, 17 Mar 2024 02:06:08 -0700 (PDT) Date: Sun, 17 Mar 2024 10:06:08 +0100 From: Matt To: "Ihor Radchenko" Cc: "emacs-orgmode" Message-ID: <18e4ba944c6.1071dbb64659068.8617018692679870359@excalamus.com> In-Reply-To: <87sf0qiizp.fsf@localhost> References: <20240311051313.3490020-1-me@bcc32.com> <18e2ef220a9.b5a8c7ae44361.2739966878741459645@excalamus.com> <87jzm7d1du.fsf@localhost> <18e440cec8c.d2bfc741504486.3314999848804225927@excalamus.com> <87sf0qiizp.fsf@localhost> Subject: How to properly attribute authorship with Git (was Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail Received-SPF: pass client-ip=136.143.188.112; envelope-from=matt@excalamus.com; helo=sender4-pp-f112.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -10.21 X-Spam-Score: -10.21 X-Migadu-Queue-Id: 04F4C75A6E X-Migadu-Scanner: mx11.migadu.com X-TUID: zCuKOwINtCdR ---- On Sat, 16 Mar 2024 11:11:38 +0100 Ihor Radchenko wrote ---=20 > I notice that you changed the commit author and only referenced Aaron in > Submitted By: metadata. >=20 > For future, we prefer keeping the original commit author in the "author" > field of the commits - this is important to keep track of the number of > changed lines for contributors without FSF copyright assignment. =20 Thank you for letting me know this is an issue. First, would you like me to update the commit? If so, I will need guidance= . The correct procedure to change the author after committing to remote is= unclear to me. I would think it's something like sync my local copy with = the latest remote version, update the author locally, and force push the ch= ange. I would then expect that the next time someone pulls, it would updat= e their local with the author change. It would, however, cause a conflict,= I think, for someone in the middle of making a change who has not synced w= ith the forced push version and is trying to push their change. Second, I can update Worg with an explanation that it's important to credit= authors using git's author field and how to do this. Unless I missed it, = worg/org-contribute makes no mention of the author field. The version of g= it packaged by my distro is 2.41.0 and, AFAICT, has no -A flag for 'git' or= 'git commit'. However, the following works on my machine and, I guess, is= the long option form: git commit --author "Arthur Override " Third, this is at least the second time I've had issues working with a diff= /patch. The reason I submitted the change the way I did is that I could no= t get 'git apply ' to work. I only got a useless error like "e= rror: corrupt patch at line 10". It's not clear to me if this is an error = on my end or if the patch is indeed ill-formatted. Can you confirm that th= e submitted patch is well-formatted? -- Matt Trzcinski Emacs Org contributor (ob-shell) Learn more about Org mode at https://orgmode.org Support Org development at=C2=A0https://liberapay.com/org-mode