From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id KLCeASBa72XaZwAA62LTzQ:P1 (envelope-from ) for ; Mon, 11 Mar 2024 20:23:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id KLCeASBa72XaZwAA62LTzQ (envelope-from ) for ; Mon, 11 Mar 2024 20:23:12 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=excalamus.com header.s=zmail header.b="dC/gfzG1"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1710184991; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=DIoaLXvfiWwflhcgpge1mG8V83zeRY13h2uIpd1SiwU=; b=Ihl+n0wxzWuvx7F7GSuHKyux1YKw9Plo96NYL5lKSSju/BnJaURXExtwKVzzj+O5onpARn T/rlTarLMAM+XQ8qLRK50Lwr2HJNuOwBq6Rg6TIQWoccCeIr0SUay3u1sHjAEQZG+uo8h2 HP6oHYoNpibkAYZ/NHdVLMiT6tvHQlfDzrugpeiPAUk4bGkL+bKNyWRBuQ4UTrFSvflAJc h3J3vGfZBnNYl55JxurZE1g7E9CUcTcenlQP3vUtBp8SZXN+CJQNvFY4hzWYbmOTGRy5yx 3Ks2PGt6mNdYN20IRIZmTnkx15xVdzfmiNWJESjq+BgbXXJ4tPu5SyohTkhRgQ== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=pass header.d=excalamus.com header.s=zmail header.b="dC/gfzG1"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none; arc=pass ("zohomail.com:s=zohoarc:i=1") ARC-Seal: i=2; s=key1; d=yhetil.org; t=1710184991; a=rsa-sha256; cv=pass; b=oXJVHNjNXeRu6zghE5tZb9QRsYp9LRU98JXhxXxJM88Yl3qr4r/Ry4Adk8tIm/HRzIn4CQ WKEK1LIhA+hvG1tU/PKuNW9Z/HcoKbbF9Ou8Tfp4nh8CqrLqpKtlvzp5VOCioZd7+GSWLJ scNqG5tNNNX00K6oKISvbwWvKvxINAhxVzrvKqQTteXE8NjTRpp52JksTPUMZVCNsDrqGX iXZhiKuqPzmbxu7B7/9lrkXqjkPv88Z34j2JkCXtIRL/p6JXrU/Lk1oRrcf1FepRbLrGtH W8y++R1iBJazaeytGynzRsE5DUIyPadoue/txuHSWfO6IwXUAIotlyEIxoSp6Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BE87F501A2 for ; Mon, 11 Mar 2024 20:23:11 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjl9z-0007Nw-Qc; Mon, 11 Mar 2024 15:18:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjl8m-0006Lz-VP for emacs-orgmode@gnu.org; Mon, 11 Mar 2024 15:16:56 -0400 Received: from sender4-op-o12.zoho.com ([136.143.188.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjl8j-00013M-8R for emacs-orgmode@gnu.org; Mon, 11 Mar 2024 15:16:52 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1710184605; cv=none; d=zohomail.com; s=zohoarc; b=OOUhUQ5MhQlX7tto+N/Tk/Ec6d0Rfdp/wM3QINXXmqMxCTBl6ZvC3HugSBs+kuAaidYwWjxKTJ/Lu2zfs7OB/y1NK5tpoc+dHuiiIJu7bRzNZ59W9djhIEXBlaVEYRolkLMhKO9KeDtouI4Rhi3VykJ/HByeWUqfhX/smz/S2RU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710184605; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=DIoaLXvfiWwflhcgpge1mG8V83zeRY13h2uIpd1SiwU=; b=ap/vgcNyUaRLTbCpuHlWYeLVqTJg3IcfEwYtgGf1tQgCrdv2YIdj2fVw3q6zH45AER99sXNU/4T7rhMM+L/RNO4H4rM0T06h7Xt4VLqYQx3h89mvQJ7qmwbJuQ45gjrk321VqjNiBbTUMlUdbGzigmp966hBTVMPsVgKf834TvQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=excalamus.com; spf=pass smtp.mailfrom=matt@excalamus.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1710184605; s=zmail; d=excalamus.com; i=matt@excalamus.com; h=Date:Date:From:From:To:To:Cc:Cc:Message-ID:In-Reply-To:References:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=DIoaLXvfiWwflhcgpge1mG8V83zeRY13h2uIpd1SiwU=; b=dC/gfzG142fr/qc88LXBKgjAtsvC0EppxC10WrXKu51joBunaXO2HxTPpyYVJBxN fKPNkOz56CICOK4poHg5raIiIlWClk3mpyXuucygZ13173RjzjtF4u9HlKO8Y1uoy9k w7vXMBpsGqdT+fjMXeuO9sMggmt5Ldnvtbtod0B0= Received: from mail.zoho.com by mx.zohomail.com with SMTP id 171018460383718.429479661063624; Mon, 11 Mar 2024 12:16:43 -0700 (PDT) Date: Mon, 11 Mar 2024 20:16:43 +0100 From: Matt To: "Aaron L. Zeng" Cc: "emacs-orgmode" Message-ID: <18e2ef220a9.b5a8c7ae44361.2739966878741459645@excalamus.com> In-Reply-To: <20240311051313.3490020-1-me@bcc32.com> References: <20240311051313.3490020-1-me@bcc32.com> Subject: Re: [PATCH] lisp/ob-shell.el: Also override explicit-shell-file-name MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail Received-SPF: pass client-ip=136.143.188.12; envelope-from=matt@excalamus.com; helo=sender4-op-o12.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -10.15 X-Spam-Score: -10.15 X-Migadu-Queue-Id: BE87F501A2 X-Migadu-Scanner: mx13.migadu.com X-TUID: PFMDhu05W0WX ---- On Mon, 11 Mar 2024 06:12:47 +0100 Aaron L. Zeng wrote ---=20 > * lisp/ob-shell.el (org-babel-shell-initialize): Override > explicit-shell-file-name in addition to shell-file-name. >=20 > When a session with shell source blocks, execution calls `shell', > which checks `explicit-shell-file-name' variable before > `shell-file-name', to determine what shell to run. If the user has > customized this variable to affect the behavior of M-x shell, > `org-babel-shell-initialize' should still run the shell specified by > the org source block's language name. >=20 > TINYCHANGE > --- > lisp/ob-shell.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/lisp/ob-shell.el b/lisp/ob-shell.el > index 551c3785d..35d9e9376 100644 > --- a/lisp/ob-shell.el > +++ b/lisp/ob-shell.el > @@ -81,7 +81,8 @@ is modified outside the Customize interface." > (lambda (body params) > =C2=A0=C2=A0=C2=A0=C2=A0 (:documentation > (format "Execute a block of %s commands with Babel." name)) > -=C2=A0=C2=A0=C2=A0=C2=A0 (let ((shell-file-name name)) > +=C2=A0=C2=A0=C2=A0=C2=A0 (let ((explicit-shell-file-name name) > + (shell-file-name name)) > =C2=A0=C2=A0=C2=A0=C2=A0 (org-babel-execute:shell body params)))) > (put fname 'definition-name 'org-babel-shell-initialize)) > (defalias (intern (concat "org-babel-variable-assignments:" name)) > --=20 > 2.42.0 Thank you for your report and the patch.=20 -- Matt Trzcinski Emacs Org contributor (ob-shell) Learn more about Org mode at https://orgmode.org Support Org development at=C2=A0https://liberapay.com/org-mode