From: Matt <matt@excalamus.com>
To: "Ihor Radchenko" <yantar92@posteo.net>
Cc: "Max Nikulin" <manikulin@gmail.com>,
"emacs-orgmode" <emacs-orgmode@gnu.org>
Subject: Re: [BUG] ob-shell: :shebang changes interpretation of :cmdline
Date: Mon, 04 Dec 2023 21:41:18 +0100 [thread overview]
Message-ID: <18c36905936.c032bac8385085.3724383818677538265@excalamus.com> (raw)
In-Reply-To: <87fs0im5lu.fsf@localhost>
---- On Mon, 04 Dec 2023 14:55:58 +0100 Ihor Radchenko wrote ---
> Matt matt@excalamus.com> writes:
>
> > > #+begin_src bash :cmdline 1 2 3
> > > printf "%s\n" "$1"
> > > #+end_src
> > >
> > > #+RESULTS:
> > > : 1
> > >
> > > #+begin_src bash :cmdline 1 2 3 :shebang #!/bin/bash
> > > printf "%s\n" "$1"
> > > #+end_src
> > >
> > > #+RESULTS:
> > > : 1 2 3
> >
> > Thank you! This makes a good test case.
>
> I am confused. Isn't it a bug?
Yes, it's a bug. And the test was wrong.
Here is a corrected version. When the bug is fixed, the following should pass. It currently fails because the first block returns 1 and the second block returns 1 2 3 (as seen in the quote). Both blocks should return 1.
(ert-deftest test-cmdline-alone-and-with-shebang-have-same-result ()
"Pass arguments to a block. Don't use shebang. Then use
shebang set to the same language as the block. The result should
be the same."
(should (equal
(org-test-with-temp-text
"#+begin_src bash :cmdline 1 2 3
echo \"$1\"
<point>
#+end_src"
(org-babel-execute-src-block))
(org-test-with-temp-text
"#+begin_src bash :cmdline 1 2 3 :shebang #!/bin/bash
echo \"$1\"
<point>
#+end_src"
(org-babel-execute-src-block)))))
next prev parent reply other threads:[~2023-12-04 20:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-18 15:54 [BUG] ob-shell: :shebang changes interpretation of :cmdline Max Nikulin
2023-11-18 18:09 ` Matt
2023-12-04 13:58 ` Ihor Radchenko
2023-12-04 20:41 ` Matt [this message]
2023-11-18 18:20 ` [BUG] ob-shell: :cmdline fails with single argument (was Re: [BUG] ob-shell: :shebang changes interpretation of :cmdline) Matt
2023-11-19 6:57 ` Max Nikulin
2023-11-19 7:57 ` Matt
2024-04-21 15:09 ` [PATCH] Re: [BUG] ob-shell: :shebang changes interpretation of :cmdline Matt
2024-04-23 10:28 ` Ihor Radchenko
2024-04-24 10:33 ` Max Nikulin
2024-04-24 12:52 ` Ihor Radchenko
2024-04-25 10:06 ` Max Nikulin
2024-04-26 11:49 ` Ihor Radchenko
2024-04-27 10:31 ` Max Nikulin
2024-04-27 13:37 ` Max Nikulin
2024-04-28 12:34 ` Ihor Radchenko
2024-06-27 12:47 ` Ihor Radchenko
2024-06-27 13:00 ` [BUG] ob-shell may use /bin/sh instead of the specified shell when :cmdline is provided (was: [PATCH] Re: [BUG] ob-shell: :shebang changes interpretation of :cmdline) Ihor Radchenko
2024-06-27 13:08 ` Ihor Radchenko
2024-04-23 10:51 ` [PATCH] Re: [BUG] ob-shell: :shebang changes interpretation of :cmdline Max Nikulin
2024-04-23 17:08 ` Max Nikulin
2024-04-26 13:09 ` [DISCUSSION] The meaning of :cmdline header argument across babel backends (was: [PATCH] Re: [BUG] ob-shell: :shebang changes interpretation of :cmdline) Ihor Radchenko
2024-04-27 10:53 ` [DISCUSSION] The meaning of :cmdline header argument across babel backends Max Nikulin
2024-04-29 13:33 ` Ihor Radchenko
2024-05-01 17:48 ` Matt
2024-05-01 18:01 ` Ihor Radchenko
2024-05-02 18:50 ` Matt
2024-05-03 12:12 ` Ihor Radchenko
2024-05-20 18:01 ` Matt
2024-05-21 10:28 ` Max Nikulin
2024-05-21 11:34 ` Ihor Radchenko
2024-06-27 14:57 ` Ihor Radchenko
2024-04-26 13:12 ` [PATCH] Re: [BUG] ob-shell: :shebang changes interpretation of :cmdline Ihor Radchenko
2024-04-27 7:43 ` Matt
2024-04-27 7:48 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18c36905936.c032bac8385085.3724383818677538265@excalamus.com \
--to=matt@excalamus.com \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).