Re: Re: Bug fix: org-mhe links don't work with mairix

[Nick Dokos <nick@gamaville.dokosmarshall.org>]

Thomas Baumann <dtbaumann@yahoo.de> wrote:

> Hi Nick,
> 
> your patch actually breaks namazu, swish and grep searches. 
> 
> A look at mh-search-choices (mh-search.el) reveals that for namazu,
> swish and grep mh-search-regexp-builder is nil and therefore 
> 
> (funcall mh-search-regexp-builder ...
> 
> raises an error. One might be tempted to solve this on the mh-e side but
> there's no reason to add a mh-search-regexp-builder for those search
> engines. There's a patch against todays git below.
> 
> BTW. Namazu and pick searches work fine without angular brackets, however, it
> doesn't harm to have them.
> 
> 
> Greetings
> Thomas
> 

Thomas,

Yes indeed: sorry for the breakage and thanks for coming up with a
fix. I agree that it's preferable to change the call site rather than
asking for changes to mh-e.

Thanks very much,
Nick

PS. For the record, the patch against mh-e that I sent earlier to both
the mh-e and org lists has also been submitted on the mh-e sourceforge
patches list at

   http://sourceforge.net/tracker/?group_id=13357&atid=313357

It's number 1965704.

> 
> --- /data/cvs/org-mode/lisp/org-mhe.el	2008-05-17 12:54:07.000000000 +0200
> +++ org-mhe.el	2008-05-17 16:55:22.000000000 +0200
> @@ -204,8 +204,10 @@
>                       (not (org-mhe-get-message-real-folder)))
>              (kill-this-buffer)
>              (mh-search "+" (list "--message-id" article))))
> -      (mh-search "+" (funcall mh-search-regexp-builder
> -			      (list (cons 'message-id article)))))

> +      (if mh-search-regexp-builder
> +          (mh-search "+" (funcall mh-search-regexp-builder
> +			      (list (cons 'message-id article))))
> +        (mh-search "+" article)))
>      (if (org-mhe-get-message-real-folder)
>          (mh-show-msg 1)
>        (kill-this-buffer)
> 

--45B245DFCA.1211054880/gamaville.dokosmarshall.org--