From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Lee <jjl@pobox.com>
Subject: Re: org-habit: allow overriding org-scheduled-past-days and always
 including time of day
Date: Sun, 03 Feb 2019 15:53:11 +0000
Message-ID: <1549209191.1791775.1649835912.01048935@webmail.messagingengine.com>
References: <1541377860.1107531.1565461832.5F447B5E@webmail.messagingengine.com>
	<87k1ladke0.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:52092)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jjl@pobox.com>) id 1gqK55-0001Vn-Sn
	for emacs-orgmode@gnu.org; Sun, 03 Feb 2019 10:53:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jjl@pobox.com>) id 1gqK55-0004F9-7w
	for emacs-orgmode@gnu.org; Sun, 03 Feb 2019 10:53:15 -0500
Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:46939)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <jjl@pobox.com>) id 1gqK55-0004Df-0S
	for emacs-orgmode@gnu.org; Sun, 03 Feb 2019 10:53:15 -0500
In-Reply-To: <87k1ladke0.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org

On Sun, 18 Nov 2018, at 23:40, Nicolas Goaziou wrote:
> * lisp/org-habit.el (org-habit-scheduled-past-days): New variable.
> 
> >  	    (when (or (and (> ddays 0) (< diff ddays))
> > -		      (> diff org-scheduled-past-days)
> > +		      (> diff (if habitp
> > +				  (or org-habit-scheduled-past-days
> > +				      org-scheduled-past-days)
> > +				org-scheduled-past-days))
> 
> Nitpick:
> 
>     (or (and habitp org-habit-scheduled-past-days)
>         org-scheduled-past-days)

Oops, I just remembered that 0 is not "falsy" in elisp.  So I'll make this change after all and submit that first patch again, again...