From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nick Dokos <nicholas.dokos@hp.com>
Subject: Re: [BUG?] subtle sequencing error when setting org-bbdb-old in
 org-bbdb.el
Date: Fri, 02 Mar 2012 12:49:19 -0500
Message-ID: <14966.1330710559@alphaville>
References: <8273.1330161610@alphaville> <87r4xgyqdm.wl%dmaus@ictsoc.de>
	<dmaus@ictsoc.de> <6717.1330381319@alphaville>
	<87k433t13f.wl%dmaus@ictsoc.de>
Reply-To: nicholas.dokos@hp.com
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:55268)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nicholas.dokos@hp.com>) id 1S3Wbq-0008BT-3T
	for emacs-orgmode@gnu.org; Fri, 02 Mar 2012 12:49:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nicholas.dokos@hp.com>) id 1S3Wbo-00068z-32
	for emacs-orgmode@gnu.org; Fri, 02 Mar 2012 12:49:37 -0500
Received: from g4t0014.houston.hp.com ([15.201.24.17]:45372)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nicholas.dokos@hp.com>) id 1S3Wbn-00067H-SH
	for emacs-orgmode@gnu.org; Fri, 02 Mar 2012 12:49:36 -0500
In-Reply-To: Message from David Maus <dmaus@ictsoc.de>
	of "Fri, 02 Mar 2012 17:32:52 +0100." <87k433t13f.wl%dmaus@ictsoc.de>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: David Maus <dmaus@ictsoc.de>
Cc: nicholas.dokos@hp.com, emacs-orgmode@gnu.org

David Maus <dmaus@ictsoc.de> wrote:

> At Mon, 27 Feb 2012 17:21:59 -0500,
> Nick Dokos wrote:
> > 
> > David Maus <dmaus@ictsoc.de> wrote:
> > 
> > > > The problem was that org-bbdb is part of org-modules by default and that
> > > > was loading org-bbdb way too early, certainly before bbdb itself was
> > > > loaded.  That would set the value to nil and nothing I would do could
> > > > change it (short of whacking it with a setq).
> > > 
> > > I pushed a patch that should fix this problem. I wrapped a
> > > `eval-after-load' around the `defvar', this should make sure that the
> > > variable is set after bbdb was loaded.
> > > 
> > 
> > I still have a problem with one configuration (but not with another),
> > but I haven't drilled down to figure out what the problem is. I was
> > wondering however if the eval-after-load should be predicated on
> > bbdb-com rather than bbdb[fn:1]: with this change, both of my tested
> > configurations work (hardly a definitive test but perhaps better than
> > nothing).
> 
> Thanks for the feedback. Eval after load 'bbdb-com would have been
> better -- I just replaced the entire defvar by a check in
> `org-bbdb-open' and `org-bbdb-store-link' for the required functions.
> 
> So this should really work now.
> 

It does, at least in the two configurations I've tested: my full-blown one
and a minimal org one with bbdb loaded after the fact.

I'll be trying it with bbdb 3.x some time soon, I hope.

Thanks very much!
Nick