Re: [BUG?] subtle sequencing error when setting org-bbdb-old in org-bbdb.el

[Nick Dokos <nicholas.dokos@hp.com>]

David Maus <dmaus@ictsoc.de> wrote:

> At Mon, 27 Feb 2012 17:21:59 -0500,
> Nick Dokos wrote:
> > 
> > David Maus <dmaus@ictsoc.de> wrote:
> > 
> > > > The problem was that org-bbdb is part of org-modules by default and that
> > > > was loading org-bbdb way too early, certainly before bbdb itself was
> > > > loaded.  That would set the value to nil and nothing I would do could
> > > > change it (short of whacking it with a setq).
> > > 
> > > I pushed a patch that should fix this problem. I wrapped a
> > > `eval-after-load' around the `defvar', this should make sure that the
> > > variable is set after bbdb was loaded.
> > > 
> > 
> > I still have a problem with one configuration (but not with another),
> > but I haven't drilled down to figure out what the problem is. I was
> > wondering however if the eval-after-load should be predicated on
> > bbdb-com rather than bbdb[fn:1]: with this change, both of my tested
> > configurations work (hardly a definitive test but perhaps better than
> > nothing).
> 
> Thanks for the feedback. Eval after load 'bbdb-com would have been
> better -- I just replaced the entire defvar by a check in
> `org-bbdb-open' and `org-bbdb-store-link' for the required functions.
> 
> So this should really work now.
> 

It does, at least in the two configurations I've tested: my full-blown one
and a minimal org one with bbdb loaded after the fact.

I'll be trying it with bbdb 3.x some time soon, I hope.

Thanks very much!
Nick