From mboxrd@z Thu Jan 1 00:00:00 1970 From: "M. P. Ashton" Subject: Re: [PATCH] (fixed) ox-confluence.el: Do not generate filled paragraphs Date: Thu, 03 Mar 2016 21:41:21 -0500 Message-ID: <1457059281.3939895.539188402.04FF3C69@webmail.messagingengine.com> References: <1457042145.2169185.539000906.0E8F7FBC@webmail.messagingengine.com> <87d1rbvzsu.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abfgE-0006Qi-Jr for emacs-orgmode@gnu.org; Thu, 03 Mar 2016 21:41:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abfgA-0003LM-1c for emacs-orgmode@gnu.org; Thu, 03 Mar 2016 21:41:26 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abfg9-0003KY-UI for emacs-orgmode@gnu.org; Thu, 03 Mar 2016 21:41:21 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 720D122863 for ; Thu, 3 Mar 2016 21:41:21 -0500 (EST) In-Reply-To: <87d1rbvzsu.fsf@nicolasgoaziou.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hello -- On Thu, Mar 3, 2016, at 07:42 PM, Nicolas Goaziou wrote: > Hello, > > "M. P. Ashton" writes: > > > * contrib/lisp/ox-confluence.el: Do not generate filled paragraphs > > > > ox-confluence was generating filled paragraphs. Since Confluence treats > > each newline as a line break, this caused unexpected formatting. Added > > a paragraph function to generate unfilled paragraphs (taken from > > ox-md.el). > > --- > > contrib/lisp/ox-confluence.el | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/contrib/lisp/ox-confluence.el > > b/contrib/lisp/ox-confluence.el > > index 9b96d5f..4304e5d 100644 > > --- a/contrib/lisp/ox-confluence.el > > +++ b/contrib/lisp/ox-confluence.el > > @@ -47,6 +47,7 @@ > > (italic . org-confluence-italic) > > (item . org-confluence-item) > > (link . org-confluence-link) > > + (paragraph . org-confluence-paragraph) > > (property-drawer . org-confluence-property-drawer) > > (section . org-confluence-section) > > (src-block . org-confluence-src-block) > > @@ -58,6 +59,12 @@ > > (underline . org-confluence-underline))) > > > > ;; All the functions we use > > +(defun org-confluence-paragraph (paragraph contents info) > > + "Transcode PARAGRAPH element for Confluence. > > +CONTENTS is the paragraph contents. INFO is a plist used as > > +a communication channel." > > + contents) > > This function doesn't unfill the paragraph. It merely returns it as it > was in the original Org document. You possibly want to call > `replace-regexp-in-string' and replace "\n" with " " in CONTENTS. That's true, but it isn't meant to unfill the paragraph: it is meant to stop the ASCII exporter from filling the paragraph. That is what was causing the problem. I could make it unfill paragraphs, but I thought it might be useful to preserve line breaks. > I'm Cc'ing the author since this is a contrib/ package. Thanks for looking this over. Let me know what would be an acceptable change if any. Best regards --Michael Ashton