From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [PATCH] Re: Latex Export: Place Caption Below Table Date: Sun, 9 Oct 2011 13:23:06 +0200 Message-ID: <12B289CE-8698-4728-9911-EF945AB39D71@gmail.com> References: <87zkhor9hb.fsf@ucl.ac.uk> <17486.1317238846@alphaville.dokosmarshall.org> <878vp2fqch.fsf@ucl.ac.uk> <701.1317652994@alphaville.dokosmarshall.org> Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([140.186.70.92]:50943) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RCrTK-0003eM-KZ for emacs-orgmode@gnu.org; Sun, 09 Oct 2011 07:23:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RCrTJ-0006MX-92 for emacs-orgmode@gnu.org; Sun, 09 Oct 2011 07:23:10 -0400 Received: from mail-ey0-f169.google.com ([209.85.215.169]:32801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RCrTJ-0006M1-2v for emacs-orgmode@gnu.org; Sun, 09 Oct 2011 07:23:09 -0400 Received: by eyb7 with SMTP id 7so1218627eyb.0 for ; Sun, 09 Oct 2011 04:23:08 -0700 (PDT) In-Reply-To: <701.1317652994@alphaville.dokosmarshall.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: nicholas.dokos@hp.com Cc: emacs-orgmode@gnu.org, Jakob Lombacher On 3.10.2011, at 16:43, Nick Dokos wrote: > Eric S Fraga wrote: >=20 >> tsd@tsdye.com (Thomas S. Dye) writes: >>=20 >>> Nick Dokos writes: >>=20 >>>> The following patch (deliberately hidden as a binary octet-stream = to keep it >>>> out of patchwork) will do that - but IMO, it would be better to = have yet another >>>> user-settable option to control the placement. >>>>=20 >>>> Nick >>>>=20 >>>>=20 >>>=20 >>> Aloha all, >>>=20 >>> The inlined patch introduces a variable >>> org-export-latex-table-caption-above to control the placement of = table >>> captions. Thanks to Nick Dokos for leading the way on this. >>>=20 >>> Tom >>=20 >>=20 >> thanks for doing this -- I was swamped last week so had no chance of >> following the thread until today! >>=20 >> One comment on the last version of the patch: would it not be better = for >> the variable to be a defcustom variable instead of defvar? >=20 > I agree - being able to customize variables without resorting to lisp = is > generally preferable: it is friendlier to newcomers and it allows even > experienced users to find the various knobs. If you provide a new patch doing a defcustom, I think this patch would = be good to have. Please go ahead and check it in! - Carsten >=20 > If the patch is deemed acceptable, it might also be nice to be able to > set the variable per-file through the OPTIONS line, but that can > certainly wait. >=20 >> Otherwise, >> the patch looks fine to me although I'm unlikely to use the new >> functionality ;-) >=20 > Unless you try to publish an article in a journal with a perverse = layout > policy :-) >=20 > I applied the patch and took it for a short spin. git complained about > trailing whitespace: >=20 > ,---- > | /home/nick/Mail/inbox/1021:197: trailing whitespace. > | (if (and floatp = org-export-latex-table-caption-above)=20 > | /home/nick/Mail/inbox/1021:212: trailing whitespace. > | (if (and floatp (not = org-export-latex-table-caption-above))=20 > | /home/nick/Mail/inbox/1021:225: trailing whitespace. > | (if (not org-export-latex-table-caption-above) = tbl)=20 > | /home/nick/Mail/inbox/1021:231: trailing whitespace. > | (if org-export-latex-table-caption-above tbl)=20 > | warning: 4 lines add whitespace errors. > `---- >=20 > but other than that the patch worked fine. >=20 > Thanks, Tom! > Nick >=20 >=20 >=20