emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nick Dokos <nicholas.dokos@hp.com>
To: Christophe Rhodes <csr21@cantab.net>
Cc: nicholas.dokos@hp.com, emacs-orgmode@gnu.org
Subject: Re: org-babel R, export, and :result value raw
Date: Thu, 15 Sep 2011 17:12:23 -0400	[thread overview]
Message-ID: <12816.1316121143@alphaville.dokosmarshall.org> (raw)
In-Reply-To: Message from Christophe Rhodes <csr21@cantab.net> of "Thu, 15 Sep 2011 21:42:45 BST." <874o0dzge2.fsf@cantab.net>

Christophe Rhodes <csr21@cantab.net> wrote:

> Hi,
> 
> Consider the following org-mode file, assuming that org-babel support
> for emacs lisp and R is active:
> 
> --- begin ---
> #+TITLE: Foo
> 
> #+begin_src emacs-lisp :exports results :results value raw
> "[[file:foo.png]]"
> #+end_src
> 
> #+results:
> [[foo.png]]
> 
> #+begin_src R :exports results :results value raw
> "[[file:bar.png]]"
> #+end_src
> #+results: 
> [[file:bar\.png]]
> ---  end  ---
> 
> The problem is probably obvious from the above, but to be explicit: the
> intent is to generate raw org-mode from the code blocks (this case is
> hugely simplified from my actual application), producing links to images
> which will then be part of the eventual exported document.  For emacs
> lisp, this works fine; for R, the path through files and specifically
> org-babel-import-elisp-from-file / org-babel-string-read causes the
> return value to be misinterpreted, introducing an extra backslash, and
> therefore generating bogus export files.
> 
> (This used to work for my use case in org-mode 7.4, and does not work in
> org-mode 7.6; I looked at HEAD to see if I could identify a fix, but did
> not find one -- I'm sorry if I missed it)
> 

This bisects to the following commit:

--8<---------------cut here---------------start------------->8---
commit b6912331715c7da08927b3636b6721af5f5e0c41
Author: Eric Schulte <schulte.eric@gmail.com>
Date:   Tue Mar 1 10:31:00 2011 -0700

    ob: allow passing elisp vectors through to code blocks
    
    * lisp/ob.el (org-babel-read): Pass elisp vectors through to code
      blocks.

diff --git a/lisp/ob.el b/lisp/ob.el
index ea1c968..b0b5fb6 100644
--- a/lisp/ob.el
+++ b/lisp/ob.el
@@ -1913,16 +1913,15 @@ (defun org-babel-script-escape (str)
 
 (defun org-babel-read (cell &optional inhibit-lisp-eval)
   "Convert the string value of CELL to a number if appropriate.
-Otherwise if cell looks like lisp (meaning it starts with a \"(\"
-or a \"'\") then read it as lisp, otherwise return it unmodified
-as a string.  Optional argument NO-LISP-EVAL inhibits lisp
-evaluation for situations in which is it not appropriate."
+Otherwise if cell looks like lisp (meaning it starts with a
+\"(\", \"'\", \"`\" or a \"[\") then read it as lisp, otherwise
+return it unmodified as a string.  Optional argument NO-LISP-EVAL
+inhibits lisp evaluation for situations in which is it not
+appropriate."
   (if (and (stringp cell) (not (equal cell "")))
       (or (org-babel-number-p cell)
           (if (and (not inhibit-lisp-eval)
-		   (or (equal "(" (substring cell 0 1))
-		       (equal "'" (substring cell 0 1))
-		       (equal "`" (substring cell 0 1))))
+		   (member (substring cell 0 1) '("(" "'" "`" "[")))
               (eval (read cell))
             (progn (set-text-properties 0 (length cell) nil cell) cell)))
     cell))
--8<---------------cut here---------------end--------------->8---

If I revert it, I get the 7.4 behavior.

The problem is that  "[..." looks like a lisp vector to this function.

Nick

  reply	other threads:[~2011-09-15 21:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15 20:42 org-babel R, export, and :result value raw Christophe Rhodes
2011-09-15 21:12 ` Nick Dokos [this message]
2011-09-15 21:45 ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12816.1316121143@alphaville.dokosmarshall.org \
    --to=nicholas.dokos@hp.com \
    --cc=csr21@cantab.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).