From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: Minor bug: org-agenda-holidays Date: Wed, 22 Dec 2010 11:24:16 -0500 Message-ID: <12593.1293035056@gamaville.dokosmarshall.org> References: <87fwtqe0y1.fsf@noorul.maa.corp.collab.net> <4D11AE5C.6060504@xnet.co.nz> <877hf2dvft.fsf@noorul.maa.corp.collab.net> Reply-To: nicholas.dokos@hp.com Return-path: Received: from [140.186.70.92] (port=37644 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PVRUe-0005mo-P2 for emacs-orgmode@gnu.org; Wed, 22 Dec 2010 11:24:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PVRUd-00018m-BA for emacs-orgmode@gnu.org; Wed, 22 Dec 2010 11:24:48 -0500 Received: from vms173007pub.verizon.net ([206.46.173.7]:54803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PVRUd-00018P-7t for emacs-orgmode@gnu.org; Wed, 22 Dec 2010 11:24:47 -0500 Received: from gamaville.dokosmarshall.org ([unknown] [173.76.32.106]) by vms173007.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0LDU0090G88G8P80@vms173007.mailsrvcs.net> for emacs-orgmode@gnu.org; Wed, 22 Dec 2010 10:24:17 -0600 (CST) In-reply-to: Message from Noorul Islam K M of "Wed, 22 Dec 2010 14:40:46 +0530." <877hf2dvft.fsf@noorul.maa.corp.collab.net> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Noorul Islam K M Cc: emacs-orgmode@gnu.org, nicholas.dokos@hp.com, Paul Sexton Noorul Islam K M wrote: > Paul Sexton writes: > > > Yes. > > "Wrong type argument: commandp, list-calendar-holidays" > > > > > > I think the following patch will fix the issue for you. > > Log > [[[ > > Make org-agenda-holidays compatible with older versions of emacs. > > * lisp/org-agenda.el (org-agenda-holidays): Make this function compatible > with older versions of emacs. > > ]]] > I don't think the patch is necessary: as Tassilo points out, list-calendar-holidays should exist in emacs versions before 23.1, it is obsoleted in 23.1 and replaced by calendar-list-holidays, but remains as an alias in versions 23.1 and after. I can confirm that in both GNU Emacs 23.2.50.1 and GNU Emacs 24.0.50.1, the alias exists and in both cases (commandp 'list-calendar-holidays) returns t. So it looks like a set-up problem at Paul's end and Tassilo's basic question remains: what version of emacs are you (Paul) running? If and when the alias goes away, and assuming org supports emacs versions before 23.1 at that point, then a compatibility patch like Noorul's might be necessary, but it's probably not a good idea to go for "premature compatibility" so to speak :-) Nick