From: Carsten Dominik <carsten.dominik@gmail.com>
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Patch to fix bug where remember template dies w/ non-filename buffer name
Date: Wed, 4 Nov 2009 14:10:43 +0100 [thread overview]
Message-ID: <11BE733E-E199-4E7F-888D-05A734B2393A@gmail.com> (raw)
In-Reply-To: <87ljincc3r.fsf@dustycloud.org>
Applied, thanks.
- Carsten
On Nov 4, 2009, at 2:28 AM, Christopher Allan Webber wrote:
> Hi,
>
> So I ran into an annoying bug where if you have an orgmode remember
> template like:
>
> ("Test" ?e "* foo \n %^{Bar}p" "~/org/test.org" "Test")
>
> Currently, if either test.org is not open, or test.org is open but the
> buffer is named something else (say, test.org<2>), orgmode will die
> when
> asking for the property (in this case, Bar).
>
> The issue was that in the org-remember-apply-template function, it
> would
> attempt to get the buffer like so:
>
> (get-buffer (file-name-nondirectory file))
>
> in other words, it would try to get the buffer with the name of
> "test.org"... no matter what that buffer was, if exists, or if it was
> even called that.
>
> I've attached a patch that fixes the problem.
>
> Thanks,
> - Christopher Allan Webber
>
> <org-remember-fix.diff>_______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
- Carsten
prev parent reply other threads:[~2009-11-04 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 1:28 Patch to fix bug where remember template dies w/ non-filename buffer name Christopher Allan Webber
2009-11-04 13:10 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11BE733E-E199-4E7F-888D-05A734B2393A@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=cwebber@dustycloud.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).