From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mNHAAr38a2IxYAEAbAwnHQ (envelope-from ) for ; Fri, 29 Apr 2022 16:57:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aN1sAr38a2JUFAEA9RJhRA (envelope-from ) for ; Fri, 29 Apr 2022 16:57:01 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AE74FF237 for ; Fri, 29 Apr 2022 16:57:00 +0200 (CEST) Received: from localhost ([::1]:42436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nkRZf-0002gP-U1 for larch@yhetil.org; Fri, 29 Apr 2022 10:26:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nkRVg-0005Zy-RR; Fri, 29 Apr 2022 10:22:16 -0400 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]:34681) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nkRVf-0005I2-A9; Fri, 29 Apr 2022 10:22:16 -0400 Received: by mail-lf1-x12b.google.com with SMTP id x33so14384744lfu.1; Fri, 29 Apr 2022 07:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=C188Tm4xJRmWLZJNHficMObNqARb0UkD2tyHMeGVHOE=; b=cWEeei2kfpeK0eC285TRx/Mtf8KQRMXl8r7vjyK5JDX8VnJ++Od+TW9M7W70qUwy9V zdxOctWmZPJzWI+Dl0MLkbXqVGMjzl6/yIyb66YParl+3blJBrf2NinyF9jne1HQeiCk TEemL6dFHmzKIb9+0yf6sfyEFZuI/vpzdcTnWiuyTuke5eCE9BpdTkO/3nBlVJ9tcaW0 XWPibt4ke2/dT51HLWMXjIYQS8gajY4XjH8uHkI6+VaM5zaV8joFzL1n7aLNJgQlFBqg eYZxdcFSNsQpyip72U10ty64SZXMI/T1mwny5q9Kj/Oov8fBw5fGfV0Gy5mL1vqJkJ6+ OVTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=C188Tm4xJRmWLZJNHficMObNqARb0UkD2tyHMeGVHOE=; b=PgYcQYTkc6zYYRbPVaZRoeh8V2IaU8KatH6QWBZwrwZ5TQVdL4QCx+7r3GL2aH5MLm 0+m2YSewLtaAKPfEkfux8haseqY5RfQPmC1JeZm3ntmRFLBKu8qFFkTYVO+2K6RiL3VW ZZAJNTrV60YQlU0lzlTxbwAvNKVbWoqo8q5nVLONTe0D8+zcjPcLiIOX05bfxc5+rQIy Z+4bzZmW/NlbSENuLV8z/XOnr2BypxcwhmeAMuFX2r47qEwhIB+mreyFlaQVXxizgy00 RdPs1QyzInf5E72Jw1ivET0uLhhpCfAoNBI84PpzQlmbxHIuUOW+vEeKdhfX9QSsKC89 wuGw== X-Gm-Message-State: AOAM532NNA9UtaTulPgBXrmaGMlhvmS3TNN1U2fywjyoO+KdzzZefjf7 VlmWHSGly4pfeVGhIxDCfoRoGpIIIbw= X-Google-Smtp-Source: ABdhPJw1xu2HFA4ZNjQzMzRRKeB1fZ/YTOey79lqU/IHUQ6YyhPlv6Hasiw4aNn1d8V5pxnU6/OeIA== X-Received: by 2002:a05:6512:2303:b0:471:b4e8:6a5b with SMTP id o3-20020a056512230300b00471b4e86a5bmr28920021lfu.285.1651242132115; Fri, 29 Apr 2022 07:22:12 -0700 (PDT) Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id z12-20020a19650c000000b004699179dec6sm252246lfb.23.2022.04.29.07.22.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Apr 2022 07:22:11 -0700 (PDT) Message-ID: <106f5128-680b-f25e-1316-f7308c49b625@gmail.com> Date: Fri, 29 Apr 2022 21:22:03 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: master 4a1f69ebca 2/2: Use (TICKS . HZ) for current-time etc. Content-Language: en-US To: Paul Eggert References: From: Max Nikulin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::12b; envelope-from=manikulin@gmail.com; helo=mail-lf1-x12b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode , emacs-devel@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651244220; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=C188Tm4xJRmWLZJNHficMObNqARb0UkD2tyHMeGVHOE=; b=rVgrCWC3suR4MkztO9PM2U4xMgO69i9iFPeug1ScQcxyaNkzQLVvcNFdDsuw5a6d+QdVog KrzvkC/r+xkA8/f42f5AL9FcKxVhe8yzX2rNmi+ZlvQlMD2VpvlkTFgEBHo8Xb2oEBzIB5 iDxapl3+QcLYAiCzzctcaI/0ICy3gsXvnopnzZcO5FjmvAsYwumMUuXKmLRJeC8YQmporo Owys/wOAViVkLDR1EsAWGEOzxiE58lzpI+Sbxo4CjHnPcc35xOoF6+Chk36ODgSf5KFVxq /nmiV33eDKsd+J0dVrMAomVWHQwX4IN3ytZQwfpQ3tycnLFegyPt1Rn1yf4s0w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651244220; a=rsa-sha256; cv=none; b=MLmGANvXRYz/KBGXdwS7c1OnOfeGy1b1yUuTGa7pWdQ/gJh7A5kDNitA7ICfo5DzE4A5GB 7RCB5SnRZc3bODv8476pC7McPEiaGdW2NbV22Jp7VfVgxqq8IGLrLaoJZ0D7nHhxFCuTzt 2o+M6A+YsNCjBIjVzz+i3dM6RayTog3mcKav83kRTGYNH4Mkb/w9yT/x6L4B1sZMkPmDYs Cm3pyE+0FsU2veXPY7PNiuc0uG2AcacW3EBEQONBney46tlkBrQnvxDJv5ncSuhTUWc2ZV sx7fu0PIYL/AGLzWGEa5vipG5WaOhK9wIRGQSaWvRWLNxAqAlv/flSkFqMf0sA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=cWEeei2k; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.40 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=cWEeei2k; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: AE74FF237 X-Spam-Score: 5.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: A+cINqnj/olH On 29/04/2022 05:27, Paul Eggert wrote: > On 4/27/22 09:55, Stefan Monnier wrote: >> Instead of rounding the times to whole seconds, wouldn't it make more >> sense to check that the difference is larger than 1s? > > org-file-newer-than-p is intended to work on filesystems like HFS+ that > store just the seconds part of the last-modified time. I have found just 2 calls of `org-file-newer-than-p' in the Org code and in both cases the intention is to check whether particular file has been updated. I have not checked Org extensions for usage of this function. I would rather assume that the code was written without any considerations concerning filesystem timestamps precision and its difference from `current-time' representation. It was still working in most real-life cases. From my point of view, it is better to rewrite `org-compile-time' to treat the case when there were no file prior to the call as that the file has been updated without comparison of timestamps, so `current-time' can be dropped to eliminate comparison of timestamp from different sources. With such modification it is better to compare file timestamps without truncation to whole seconds, however I have not tried to create an example where fractional seconds may change behavior.