From mboxrd@z Thu Jan  1 00:00:00 1970
From: Frederick Giasson <fred@fgiasson.com>
Subject: Re: [PATCH] expose nrepl's timeout setting in ob-clojure.el
Date: Mon, 11 Apr 2016 10:03:08 -0400
Message-ID: <0b7090aa-5c49-9364-e18c-28627ae3911f@fgiasson.com>
References: <56FABD8E.2000705@fgiasson.com> <87twjfcbt6.fsf@nicolasgoaziou.fr>
	<570521D3.4030009@fgiasson.com> <87vb3pnad5.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42518)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred@fgiasson.com>) id 1apcQV-0004F3-4j
	for emacs-orgmode@gnu.org; Mon, 11 Apr 2016 10:02:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fred@fgiasson.com>) id 1apcQP-0007Co-Hn
	for emacs-orgmode@gnu.org; Mon, 11 Apr 2016 10:02:51 -0400
Received: from s052.panelboxmanager.com ([72.55.186.33]:57718)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred@fgiasson.com>) id 1apcQP-0007CI-ED
	for emacs-orgmode@gnu.org; Mon, 11 Apr 2016 10:02:45 -0400
Received: from mailnull by s052.panelboxmanager.com with sa-checked (Exim
	4.86_1) (envelope-from <fred@fgiasson.com>) id 1apcQM-001OH4-Nq
	for emacs-orgmode@gnu.org; Mon, 11 Apr 2016 10:02:42 -0400
Received: from modemcable161.56-23-96.mc.videotron.ca ([96.23.56.161]:49317
	helo=[192.168.0.13]) by s052.panelboxmanager.com with esmtpsa
	(TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1)
	(envelope-from <fred@fgiasson.com>) id 1apcQM-001OGr-Gr
	for emacs-orgmode@gnu.org; Mon, 11 Apr 2016 10:02:42 -0400
In-Reply-To: <87vb3pnad5.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: emacs-orgmode@gnu.org

Hi Nicolas,

> Some keywords are missing:
>
>    :version "25.1"
>    :package-version '(Org . "9.0")
>
> and perhaps
>
>    :safe #'wholenump

Ok good, added.


>>   (defcustom org-babel-clojure-backend
>>     (cond ((featurep 'cider) 'cider)
>>   	(t 'slime))
>> @@ -94,8 +100,9 @@
>>          (let ((result-params (cdr (assoc :result-params params))))
>>   	 (setq result
>>   	       (nrepl-dict-get
>> -		(nrepl-sync-request:eval
>> -		 expanded (cider-current-connection) (cider-current-session))
>> +		(let ((nrepl-sync-request-timeout org-babel-clojure-sync-nrepl-timeout))
>> +		  (nrepl-sync-request:eval
>> +		   expanded (cider-current-connection) (cider-current-session)))
> You forgot to
>
> (defvar nrepl-sync-request-timeout)

This one is defined in the nREPL package. Maybe there is something that 
I don't understand, but do I have to re-defined it here?

> I also think it makes sense to merge the 3 patches.

Ok will do.

Thanks,

Fred