From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Agenda todo filter order Date: Fri, 6 May 2011 08:24:58 +0200 Message-ID: <08D28BBE-80FF-4754-97BB-9674D2EB7CB5@gmail.com> References: <87zknlhici.fsf@norang.ca> <87tydthi1x.fsf@norang.ca> Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([140.186.70.92]:50684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QIETN-00024z-TN for emacs-orgmode@gnu.org; Fri, 06 May 2011 02:25:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QIETN-0002P1-0e for emacs-orgmode@gnu.org; Fri, 06 May 2011 02:25:09 -0400 Received: from mail-ew0-f41.google.com ([209.85.215.41]:58723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QIETM-0002JN-S5 for emacs-orgmode@gnu.org; Fri, 06 May 2011 02:25:08 -0400 Received: by ewy9 with SMTP id 9so979336ewy.0 for ; Thu, 05 May 2011 23:25:03 -0700 (PDT) In-Reply-To: <87tydthi1x.fsf@norang.ca> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bernt Hansen Cc: emacs-orgmode@gnu.org Hi Bernt, I don't see a compelling reason why these two skipping checks could not be exchanged: = --------------------------------------------------------------------------= --------- diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 609edd4..a386a18 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -4573,6 +4573,7 @@ the documentation of `org-diary'." (goto-char (point-min)) (while (re-search-forward regexp nil t) (catch :skip + (org-agenda-skip) (save-match-data (beginning-of-line) (setq beg (point) end (save-excursion (outline-next-heading) = (point))) @@ -4581,7 +4582,6 @@ the documentation of `org-diary'." (or org-agenda-todo-list-sublevels (org-end-of-subtree = 'invisible)) (throw :skip nil))) (goto-char beg) - (org-agenda-skip) (goto-char (match-beginning 1)) (setq marker (org-agenda-new-marker (match-beginning 0)) category (org-get-category) = --------------------------------------------------------------------------= --------- Does anyone else see a reason why this could cause a problem? Bernt, maybe just try out this patch and report back? - Carsten On 20.4.2011, at 02:39, Bernt Hansen wrote: > scheduled date and that sends the message... oops> >=20 > Hi Carsten, >=20 > I'm trying to tune my shiny new block agenda so it has a section that > displays non-project tasks without a scheduled date or deadline date = in > the future. >=20 > I have a non-standard skipping function that skips project trees which > I'm using in this agenda so what is left should only be non-project > tasks. My agenda with only this non-standard skipping function works > perfectly and gives me a list of only non-project tasks. >=20 > I don't really want to see non-project tasks with a scheduled or > deadline date in the future. I added org-agenda-todo-ignore-scheduled > and org-agenda-todo-ignore-deadlines to 'future to this agenda view = and > now I get extra project tasks in the list which is incorrect. >=20 > It seems the org-agenda-todo-ignore-scheduled (and deadlines) vars are > applied to the list of todo tasks first -- so any projects that have a > scheduled or deadline date are skipped (but not the entire tree - just > the top-level project task) -- this makes all of the project subtasks > appear in my 'non-project' task list which is wrong. >=20 > If the non-standard skipping function was applied first and then the > test for scheduled/deadline I think it work work the way I want. Is > this hard to change? >=20 > Example: >=20 > --8<---------------cut here---------------start------------->8--- > * TODO Project task > SCHEDULED: <2011-04-12 Tue> > ** TODO Subtask 1 > ** TODO Subtask 2 > * TODO Non project task > * TODO Another non-project-task > DEADLINE: <2011-06-03 Fri> > * TODO Some future non-project task > SCHEDULED: <2011-06-18 Sat> > --8<---------------cut here---------------end--------------->8--- >=20 > My agenda view for non-project tasks should show only >=20 > * TODO Non project task > * TODO Another non-project-task > * TODO Some future non-project task >=20 > but with (setq org-agenda-todo-ignore-scheduled 'future) the top level > 'Project task' is skipped and 'Subtask 1' show up (and is considered = not > a project since it has no subtasks) >=20 > If this can't be changed for some technical reason I guess I can make = my > skipping function more intelligent and look up the hierarchy as well = to > make sure this task is not under some other project task but I didn't > think that would be necessary to accomplish what I want. >=20 > Do you have any suggestions for how I get to my desired end result? >=20 > Regards, > Bernt