From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sChhDJqTv17WBQAA0tVLHw (envelope-from ) for ; Sat, 16 May 2020 07:17:46 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8PMJCJqTv15sFwAAbx9fmQ (envelope-from ) for ; Sat, 16 May 2020 07:17:46 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B04FE9400F4 for ; Sat, 16 May 2020 07:17:45 +0000 (UTC) Received: from localhost ([::1]:45568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZr4q-00042W-Ed for larch@yhetil.org; Sat, 16 May 2020 03:17:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZr4U-00041x-Nf for emacs-orgmode@gnu.org; Sat, 16 May 2020 03:17:22 -0400 Received: from smtp1-g21.free.fr ([2a01:e0c:1:1599::10]:12209) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZr4T-0003iy-45 for emacs-orgmode@gnu.org; Sat, 16 May 2020 03:17:22 -0400 Received: from [192.168.1.75] (unknown [109.190.20.186]) (Authenticated sender: linda.gostiaux) by smtp1-g21.free.fr (Postfix) with ESMTPSA id DAE7FB0055E; Sat, 16 May 2020 09:17:07 +0200 (CEST) Subject: Re: [PATCH] Add margin option to float for figure in ox-latex.el To: Kyle Meyer , Pablo Palazon , emacs-orgmode@gnu.org References: <87o8qoqtau.fsf@kyleam.com> From: Louis Gostiaux Message-ID: <027854c0-c210-5305-a9cc-d07f124df1de@free.fr> Date: Sat, 16 May 2020 09:17:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <87o8qoqtau.fsf@kyleam.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: fr-FR Received-SPF: none client-ip=2a01:e0c:1:1599::10; envelope-from=louis.gostiaux@free.fr; helo=smtp1-g21.free.fr X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Thomas S. Dye" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 1.99 X-TUID: HlTUtpRPJdqn Hi all, Kyle could you please redirect also to Pablo's patch ? Couldn't find it. That's also great that an exporter for tufte exists. However, as far as I understood, marginfigure is not exclusevely usedby tufte. I guess the marginfigure environment coule be supported in the generic latex export, and the tufte export could simply focus on the environments specific to tufte ? That's great you found my post. At the time Bastien Guerry had replied, but no news since then. Louis. Le 16/05/2020 à 08:37, Kyle Meyer a écrit : > Pablo Palazon writes: > >> I've created a path to add a new option to float properties for figures on >> latex. This is my first change for org-mode, and I don't really sure if >> this is the correct way to do it. > Thank you! > >> * lisp/ox-latex.el (org-latex--inline-image): Include margin option >> to create marginfigure environment for figures. It's useful for tufte >> latex class, where with this environment shows the figure in the margin. > I wondered if something like this had been proposed or discussed before. > Searching the list, I see a patch [0] very similar to yours from a > couple of months back that didn't get a response (author added to cc). > > Further back, there is a thread about an exporter Thomas Dye (+cc) wrote > to handle marginfigure and some other Tufte-y things [1]. It looks like > the code is available at , > though I'm not sure if it still works with the current Org. > > As for the proposed patch, while I think the specific code change itself > looks fine, skimming through the above thread makes me think that adding > marginfigure to ox-latex.el without considering similar cases may not be > the right approach. What do others think? > > > [0]: https://yhetil.org/orgmode/35aac187-b751-5723-0f15-be6605fb8ea2@free.fr/ > [1]: https://yhetil.org/orgmode/m2h9hsgdo2.fsf@tsdye.com/