From: Nick Savage <nick@nicksavage.ca>
To: emacs-orgmode@gnu.org
Subject: Re: bug#47088: org-w3m: handle w3m-image link information
Date: Thu, 6 May 2021 19:56:33 -0400 [thread overview]
Message-ID: <0190f7aa-3656-dbac-2419-ac525426c909@nicksavage.ca> (raw)
In-Reply-To: <20210506220515.fr7ebcvvtb3jj5yp@E15-2016.optimum.net>
I haven't opened up the code yet to take a look, but I likely will take
a crack at some of these items in the future as low-hanging fruit
refactoring project.
On 5/6/21 6:05 PM, Boruch Baum wrote:
> (org-w3m-get-image-end): New function, for w3m-img links.
>
> 3] As mentioned in the patch, and in the commit message, there seem to
> be several functioned unused in the code base that could be
> candidates for removal...
>
> org-w3m-get-anchor-start
> org-w3m-no-prev-link-p
> org-w3m-get-prev-link-start
>
> 4] Additionally, in performing the merge I came across function
> org-string-nw-p, which seems to be an unnecessary duplicate of the
> emacs core function string-blank-p. It may be that historically you
> once needed your own home-made functions/macros, but now that emacs
> core has them, you may want to consider a refactor.
next prev parent reply other threads:[~2021-05-06 23:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210312062614.usandeuwplmn7fu3@E15-2016.optimum.net>
2021-05-05 8:16 ` bug#47088: org-w3m: handle w3m-image link information Bastien
2021-05-06 22:05 ` Boruch Baum
2021-05-06 23:56 ` Nick Savage [this message]
2021-05-08 7:44 ` Bastien
2021-05-08 11:35 ` Nicholas Savage
2021-05-09 6:50 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0190f7aa-3656-dbac-2419-ac525426c909@nicksavage.ca \
--to=nick@nicksavage.ca \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).