From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Bug found (but don't know to fix) Date: Wed, 21 May 2008 19:16:42 +0200 Message-ID: <016C01BD-F455-4CA8-AF44-9DF05BF23CCC@uva.nl> References: <4831F82F.90902@gmail.com> <483430E0.9040302@gmail.com> Mime-Version: 1.0 (Apple Message framework v919.2) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jyrvj-0006K3-3L for emacs-orgmode@gnu.org; Wed, 21 May 2008 13:16:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jyrvi-0006Ig-9G for emacs-orgmode@gnu.org; Wed, 21 May 2008 13:16:46 -0400 Received: from [199.232.76.173] (port=55146 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jyrvh-0006IO-Sh for emacs-orgmode@gnu.org; Wed, 21 May 2008 13:16:45 -0400 Received: from korteweg.uva.nl ([146.50.98.70]:9315) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jyrvh-00077r-PS for emacs-orgmode@gnu.org; Wed, 21 May 2008 13:16:46 -0400 In-Reply-To: <483430E0.9040302@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Wanrong Lin Cc: emacs-orgmode@gnu.org On May 21, 2008, at 4:25 PM, Wanrong Lin wrote: > Hi, Carsten, > > Thanks a lot for the patch. I tried it, but it does not work. I > traced into the "org-open-at-point" function and found the patch is > not executed because the condition *"(stringp cmd)" *is not > satisfied, as "cmd" is a list "(w32-shell-execute "open" file)". > This function seems a little bit too complicated for me to sort out, > would you mind taking another look into it, or giving some > suggestion on how to fix it? Thank you. Hi Wanrong, How about this patch then: diff --git a/lisp/org.el b/lisp/org.el index 9094204..4e2aa58 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -7385,7 +7385,9 @@ If the file does not exist, an error is thrown." (setq cmd (replace-match "%s" t t cmd))) (while (string-match "%s" cmd) (setq cmd (replace-match - (save-match-data (shell-quote-argument file)) + (save-match-data + (shell-quote-argument + (convert-standard-filename file))) t t cmd))) (save-window-excursion (start-process-shell-command cmd nil cmd) @@ -7398,7 +7400,8 @@ If the file does not exist, an error is thrown." (if line (goto-line line) (if search (org-link-search search)))) ((consp cmd) - (eval cmd)) + (let ((file (convert-standard-filename file))) + (eval cmd))) (t (funcall (cdr (assq 'file org-link-frame-setup)) file))) (and (org-mode-p) (eq old-mode 'org-mode) (or (not (equal old-buffer (current-buffer)))