emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* commit 860bcfbf93
@ 2016-01-24 10:24 Achim Gratz
  2016-01-25 18:34 ` commit 7b9f2fba66 (was: commit 860bcfbf93) Achim Gratz
  0 siblings, 1 reply; 7+ messages in thread
From: Achim Gratz @ 2016-01-24 10:24 UTC (permalink / raw)
  To: emacs-orgmode


This commit is marked as TINYCHANGE, but committed by the author
himself.  How and why did someone not having assigned copyright to the
FSF get push access to the Orgmode repository?


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf Q+, Q and microQ:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

^ permalink raw reply	[flat|nested] 7+ messages in thread

* commit 7b9f2fba66 (was: commit 860bcfbf93)
  2016-01-24 10:24 commit 860bcfbf93 Achim Gratz
@ 2016-01-25 18:34 ` Achim Gratz
  2016-01-26  0:11   ` Rafael Laboissiere
  2016-01-26  2:06   ` font bug in 0.9.16 Robert Horn
  0 siblings, 2 replies; 7+ messages in thread
From: Achim Gratz @ 2016-01-25 18:34 UTC (permalink / raw)
  To: emacs-orgmode

Achim Gratz writes:
> This commit is marked as TINYCHANGE, but committed by the author
> himself.  How and why did someone not having assigned copyright to the
> FSF get push access to the Orgmode repository?

The same thing again, with no previous communication on the mailing list
and again on maint without a clear indication of whether that's
changing functionality.

Again, who gave this person the commit bit?


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf microQ V2.22R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: commit 7b9f2fba66 (was: commit 860bcfbf93)
  2016-01-25 18:34 ` commit 7b9f2fba66 (was: commit 860bcfbf93) Achim Gratz
@ 2016-01-26  0:11   ` Rafael Laboissiere
  2016-01-26 17:11     ` commit 7b9f2fba66 Achim Gratz
  2016-01-26  2:06   ` font bug in 0.9.16 Robert Horn
  1 sibling, 1 reply; 7+ messages in thread
From: Rafael Laboissiere @ 2016-01-26  0:11 UTC (permalink / raw)
  To: Achim Gratz; +Cc: emacs-orgmode

* Achim Gratz <Stromeko@nexgo.de> [2016-01-25 19:34]:

> Achim Gratz writes:
>
>> This commit is marked as TINYCHANGE, but committed by the author 
>> himself.  How and why did someone not having assigned copyright to the 
>> FSF get push access to the Orgmode repository?
>
> The same thing again, with no previous communication on the mailing 
> list and again on maint without a clear indication of whether that's 
> changing functionality.
>
> Again, who gave this person the commit bit?

I am the author of the commits and I sincerely apologize for breaking the 
usual rules of development of Org-mode.

I contributed in the past to both Worg and Org-mode itself.  I do not 
remember who gave me push access to the Git repositories, it was some 
years ago.  I have forgotten that all my contributions and patches to 
Org-mode where integrated by others into Git.  This time, when I fixed 
the bugs in my commits 860bcfb and 7b9f2fb, I thought that I have pushed 
changes in the past myself.  Sorry for the confusion.

As a matter of fact, none of those two commits introduced changes in 
functionality.

Nicolas Goaziou contacted me privately and suggested to get the copyright 
assignment from FSF.  I am about to sent the form to them and will keep 
you informed when it is finished.  In the meanwhile, I will send my 
patches to the ML, if there will be any.

Best regards,

Rafael Laboissière

^ permalink raw reply	[flat|nested] 7+ messages in thread

* font bug in 0.9.16
  2016-01-25 18:34 ` commit 7b9f2fba66 (was: commit 860bcfbf93) Achim Gratz
  2016-01-26  0:11   ` Rafael Laboissiere
@ 2016-01-26  2:06   ` Robert Horn
  2016-01-26 14:10     ` Robert Horn
  1 sibling, 1 reply; 7+ messages in thread
From: Robert Horn @ 2016-01-26  2:06 UTC (permalink / raw)
  To: emacs-orgmode


I just tried 0.9.16 by

1) clone from github
2) git checkout v0.9.16
3) make install
4) start fresh emacs
5) M-x mu4e
6) "bt"

when displaying a non-empty headers from search (e.g., "bt" or "bu" when
unread mail is present, I get the following

Debugger entered--Lisp error: (void-function add-face-text-property)
  add-face-text-property(0 63 mu4e-header-face t #("08:31:05 PM  S                 Robert Horn            + testing" 0 11 (help-echo "Mon 25 Jan 2016 08:31:05 PM EST") 13 14 (help-echo "(seen)")))
  mu4e~headers-line-apply-flag-face((:docid 163426 :thread (:path "00" :level 0 :has-child t) :subject "testing" :from (("Robert Horn" . "rjhorn@alum.mit.edu")) :to ((nil . "rjhorn@alum.mit.edu")) :date (22182 52313 0) :size 284 :message-id "m3k2mx6s9y.fsf@alum.mit.edu" :path "/home/other-disk/hornrj/mail/sent/cur/20160125-a57c19-quad:2,S" :maildir "/sent" :priority normal :flags (seen)) #("08:31:05 PM  S                 Robert Horn            + testing" 0 11 (help-echo "Mon 25 Jan 2016 08:31:05 PM EST") 13 14 (help-echo "(seen)")))
  mu4e~headers-line-handler((:docid 163426 :thread (:path "00" :level 0 :has-child t) :subject "testing" :from (("Robert Horn" . "rjhorn@alum.mit.edu")) :to ((nil . "rjhorn@alum.mit.edu")) :date (22182 52313 0) :size 284 :message-id "m3k2mx6s9y.fsf@alum.mit.edu" :path "/home/other-disk/hornrj/mail/sent/cur/20160125-a57c19-quad:2,S" :maildir "/sent" :priority normal :flags (seen)) #("08:31:05 PM  S                 Robert Horn            + testing" 0 11 (help-echo "Mon 25 Jan 2016 08:31:05 PM EST") 13 14 (help-echo "(seen)")))
  mu4e~headers-header-handler((:docid 163426 :thread (:path "00" :level 0 :has-child t) :subject "testing" :from (("Robert Horn" . "rjhorn@alum.mit.edu")) :to ((nil . "rjhorn@alum.mit.edu")) :date (22182 52313 0) :size 284 :message-id "m3k2mx6s9y.fsf@alum.mit.edu" :path "/home/other-disk/hornrj/mail/sent/cur/20160125-a57c19-quad:2,S" :maildir "/sent" :priority normal :flags (seen)))
  byte-code("\306	\205\x01\307\310\311	#\210\312	\313\"\203\0\n	!\210\202\x01\312	\314\"\203+\v\312	\314\"!\210\202\x01\312	\315\"\203<\f\312	\315\"!\210\202\x01\312	\316\"\203I\r \210\202\x01\312	\317\"\203_\x0e&\312	\320\"\312	\321\"\"\210\202\x01\312	\322\"\203q\x0e'\312	\323\"!\210\202\x01\324	\325\"\203\203\x0e(\312	\325\"!\210\202\x01\312	\326\"\203\231\x0e)\312	\326\"\312	\327\"\"\210\202\x01\312	\330\"\203\253\x0e*\312	\330\"!\210\202\x01\312	\331\"\203\305\x0e+\312	\331\"\312	\332\"\312	\333\"#\210\202\x01\312	\334\"\203\343\x0e,\312	\334\"\312	\335\"\312	\320\"\312	\336\"$\210\202\x01\312	\337\"\203\362\x0e-	!\210\202\x01\312	\340\"\203\b\x0e.\312	\340\"\312	\341\"\"\210\202\x01\342\343	\"\210\306\344\345\217\211\204\0\306)\207" [inhibit-quit sexp mu4e-header-func mu4e-found-func mu4e-view-func mu4e-erase-func nil mu4e-log from-server "%S" plist-get :date :found :view :erase :sent :docid :path :pong :props plist-member :contacts :update :move :remove :compose :original :include :temp :what :param :info :error :message mu4e-message "Unexpected data from server [%S]" (byte-code "\305\b	\"\306\211^[\211\205;\307\310\311	\"\312\"	G\v\313\225\\Y\205;	\313\225\306O\314\315	\313\vO\316\317#!\211\205;	\v\306O\n@+\207" [mu4e~cookie-matcher-rx mu4e~proc-buf objcons sexp-len b string-match nil string-to-number match-string 1 16 0 read-from-string decode-coding-string utf-8 t] 6) ((error)) mu4e-sent-func mu4e-pong-func mu4e-contacts-func mu4e-update-func mu4e-remove-func mu4e-compose-func mu4e-temp-func mu4e-info-func mu4e-error-func] 8)
  mu4e~proc-filter(#<process  *mu4e-proc*> "\376172\377(\n	:docid
  163426\n	:thread (:path \"00\" :level 0 :has-child t)\n	:subject
  \"testing\"\n	:from ((\"Robert Horn\" . \"rjhorn@alum.mit.edu\"))\n
  :to ((nil . \"rjhorn@alum.mit.edu\"))\n	:date (22182 52313 0)\n
  :size 284\n	:message-id \"m3k2mx6s9y.fsf@alum.mit.edu\"\n	:path
  \"/home/other-disk/hornrj/mail/sent/cur/20160125-a57c19-quad:2,S\"\n
  :maildir \"/sent\"\n	:priority normal\n	:flags
  (seen)\n)\n\n\376199\377(\n	:docid 163427\n	:thread (:path \"00:00\"
  :level 1 :first-child t :duplicate t)\n	:subject \"testing\"\n
  :from ((\"Robert Horn\" . \"rjhorn@alum.mit.edu\"))\n	:to ((nil
  . \"rjhorn@alum.mit.edu\"))\n	:date (22182 52313 0)\n	:size 3273\n
  :message-id \"m3k2mx6s9y.fsf@alum.mit.edu\"\n	:path
  \"/home/other-disk/hornrj/mail/inbox.maildir/cur/1453771891.9988_0.quad:2,S\"\n
  :maildir \"/inbox.maildir\"\n	:priority normal\n	:flags
  (seen)\n)\n\n\37618e\377(\n	:docid 163424\n	:thread (:path \"01\"
  :level 0)\n	:subject \"testing\"\n	:from ((nil
  . \"hornrj@shuttle.robs.office\"))\n	:to ((nil
  . \"hornrj@shuttle.robs.office\"))\n	:date (22182 51457 0)\n	:size
  874\n	
... long list of other emails headers etc. removed.

There is no problem when using v0.9.13 (the next earlier tag).

This is using Emacs 24.3.1 on Linux.

R Horn
-- 
Sent with my mu4e

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: font bug in 0.9.16
  2016-01-26  2:06   ` font bug in 0.9.16 Robert Horn
@ 2016-01-26 14:10     ` Robert Horn
  0 siblings, 0 replies; 7+ messages in thread
From: Robert Horn @ 2016-01-26 14:10 UTC (permalink / raw)
  To: emacs-orgmode


Robert Horn writes:

Apologies, sent to the wrong list

R Horn
-- 
Sent with my mu4e

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: commit 7b9f2fba66
  2016-01-26  0:11   ` Rafael Laboissiere
@ 2016-01-26 17:11     ` Achim Gratz
  2016-03-12  9:59       ` Rafael Laboissiere
  0 siblings, 1 reply; 7+ messages in thread
From: Achim Gratz @ 2016-01-26 17:11 UTC (permalink / raw)
  To: emacs-orgmode

Rafael Laboissiere writes:
> I am the author of the commits and I sincerely apologize for breaking
> the usual rules of development of Org-mode.

Thanks.

> I contributed in the past to both Worg and Org-mode itself.  I do not
> remember who gave me push access to the Git repositories, it was some
> years ago.  I have forgotten that all my contributions and patches to
> Org-mode where integrated by others into Git.  This time, when I fixed
> the bugs in my commits 860bcfb and 7b9f2fb, I thought that I have
> pushed changes in the past myself.  Sorry for the confusion.

It's quite likely you were supposed to have access to Worg.  That
shouldn't give you commit access to the Org repository however.  So I'd
still would like to know how you've gotten the latter part, since this
seems to indicate some oversight somewhere.  Somebody with access to the
server config should at least check that all people with permission to
commit have assigned copyright to the FSF, IMHO.

> As a matter of fact, none of those two commits introduced changes in
> functionality.

Thanks.  If you commit something to maint, you're supposed to merge that
bugfix back into master yourself.

> Nicolas Goaziou contacted me privately and suggested to get the
> copyright assignment from FSF.  I am about to sent the form to them
> and will keep you informed when it is finished.  In the meanwhile, I
> will send my patches to the ML, if there will be any.

Getting the copyright assigned would be good since if you've had some
previous changes (not the two commits you did yourself), then quite
likely you've already exhausted your TINYCHANGE budget.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf rackAttack V1.04R1:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: commit 7b9f2fba66
  2016-01-26 17:11     ` commit 7b9f2fba66 Achim Gratz
@ 2016-03-12  9:59       ` Rafael Laboissiere
  0 siblings, 0 replies; 7+ messages in thread
From: Rafael Laboissiere @ 2016-03-12  9:59 UTC (permalink / raw)
  To: emacs-orgmode

* Achim Gratz <Stromeko@nexgo.de> [2016-01-26 18:11]:

> Getting the copyright assigned would be good since if you've had some 
> previous changes (not the two commits you did yourself), then quite 
> likely you've already exhausted your TINYCHANGE budget.

The papers have been signed with the Free Software Foundation.  I went 
ahead and changed the org-contribute.org file in Worg to reflect the new 
situation [commit 697ec6c].  Please, tell me whether I should send the 
PDF file with the signed form to someone.

Best,

Rafael Laboissière

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2016-03-12  9:59 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-24 10:24 commit 860bcfbf93 Achim Gratz
2016-01-25 18:34 ` commit 7b9f2fba66 (was: commit 860bcfbf93) Achim Gratz
2016-01-26  0:11   ` Rafael Laboissiere
2016-01-26 17:11     ` commit 7b9f2fba66 Achim Gratz
2016-03-12  9:59       ` Rafael Laboissiere
2016-01-26  2:06   ` font bug in 0.9.16 Robert Horn
2016-01-26 14:10     ` Robert Horn

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).