emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: Agenda view switches back to week with "g" [7.4]
@ 2010-12-21 14:36 Joel J. Adamson
  2010-12-22 11:54 ` - Bug: [CLOSED ?] " Giovanni Ridolfi
  0 siblings, 1 reply; 8+ messages in thread
From: Joel J. Adamson @ 2010-12-21 14:36 UTC (permalink / raw)
  To: emacs-orgmode


[-- Attachment #1.1: Type: text/plain, Size: 4189 bytes --]



Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------

When I go into the weekly agenda, I use "d" (org-agenda-day-view) to get
the daily view, which brings up the first day of the week.  I then press
"g" (org-agenda-redo) which takes me back to week view.  Previously "g"
would refresh the day-view bringing me to the current day of the week.

Emacs  : GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.22.0)
 of 2010-12-20 on edna
Package: Org-mode version 7.4

current state:
==============
(setq
 org-export-latex-after-initial-vars-hook '(org-beamer-after-initial-vars)
 org-default-priority 68
 org-speed-command-hook '(org-speed-command-default-hook
			  org-babel-speed-command-hook)
 org-agenda-custom-commands '(("c" "Agenda with Current Projects"
			       ((agenda "") (tags "CURRENT" nil)))
			      )
 org-agenda-files '("~/Documents/org/inbox.org" "~/Documents/org/appts.org"
		    "~/Documents/org/proj.org")
 org-clock-into-drawer t
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-agenda-todo-ignore-scheduled t
 org-export-blocks-postblock-hook '(org-exp-res/src-name-cleanup)
 org-deadline-warning-days 7
 org-export-latex-format-toc-function 'org-export-latex-format-toc-default
 org-tags-exclude-from-inheritance '("CURRENT")
 org-tab-first-hook '(org-hide-block-toggle-maybe
		      org-src-native-tab-command-maybe
		      org-babel-hide-result-toggle-maybe)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
		     org-src-mode-configure-edit-buffer)
 org-finalize-agenda-hook '(org-agenda-to-appt)
 org-confirm-shell-link-function 'yes-or-no-p
 org-export-first-hook '(org-beamer-initialize-open-trackers)
 org-use-tag-inheritance nil
 org-clock-persist t
 org-agenda-include-all-todo t
 org-clock-sound "/usr/share/sounds/freedesktop/stereo/complete.oga"
 org-todo-keywords '((sequence "reminder(r)" "todo(t)" "wait(w!)" "|"
		      "done(d!)")
		     )
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-babel-pre-tangle-hook '(save-buffer)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
		  org-cycle-show-empty-lines
		  org-optimize-window-after-visibility-change)
 org-export-preprocess-before-normalizing-links-hook '(org-remove-file-link-modifiers)
 org-agenda-window-frame-fractions '(1.0 . 1.0)
 org-mode-hook '(org-clock-load
		 #[nil "\300\301\302\303\304$\207"
		   [org-add-hook change-major-mode-hook org-show-block-all
		    append local]
		   5]
		 #[nil "\300\301\302\303\304$\207"
		   [org-add-hook change-major-mode-hook
		    org-babel-show-result-all append local]
		   5]
		 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point
			  org-babel-execute-safely-maybe)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-clock-modeline-total 'today
 org-agenda-todo-ignore-with-date t
 org-export-interblocks '((lob org-babel-exp-lob-one-liners)
			  (src org-babel-exp-inline-src-blocks))
 org-occur-hook '(org-first-headline-recenter)
 org-export-preprocess-before-selecting-backend-code-hook '(org-beamer-select-beamer-code)
 org-agenda-todo-ignore-deadlines t
 org-agenda-use-time-grid nil
 org-export-latex-final-hook '(org-beamer-amend-header org-beamer-fix-toc
			       org-beamer-auto-fragile-frames
			       org-beamer-place-default-actions-for-lists)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-idle-time 10
 org-export-blocks '((src org-babel-exp-src-blocks nil)
		     (comment org-export-blocks-format-comment t)
		     (ditaa org-export-blocks-format-ditaa nil)
		     (dot org-export-blocks-format-dot nil))
 )
-- 
Joel J. Adamson	-- http://www.unc.edu/~adamsonj
University of North Carolina at Chapel Hill
CB #3280, Coker Hall
Chapel Hill, NC 27599-3280

[-- Attachment #1.2: Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: - Bug: [CLOSED ?] Agenda view switches back to week with "g" [7.4]
  2010-12-21 14:36 Bug: Agenda view switches back to week with "g" [7.4] Joel J. Adamson
@ 2010-12-22 11:54 ` Giovanni Ridolfi
  2011-01-26 17:19   ` Michael Brand
  0 siblings, 1 reply; 8+ messages in thread
From: Giovanni Ridolfi @ 2010-12-22 11:54 UTC (permalink / raw)
  To: Joel J. Adamson; +Cc: emacs-orgmode

adamsonj@email.unc.edu (Joel J. Adamson) writes:

> ------------------------------------------------------------------------
> Emacs  : GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.22.0)
>  of 2010-12-20 on edna
> Package: Org-mode version 7.4

>
> When I go into the weekly agenda, I use "d" (org-agenda-day-view) to get
> the daily view, 
> which brings up the first day of the week.  

Hi, Joel,

today is Wednesday so pressing "d" brings me the third day of the week.

> I then press
> "g" (org-agenda-redo)  which takes me back to week view.  

But here, with 
Org-mode version 7.4 commit-8eee473f3760a3ccbdeea98e4de71d6a2464f9df
GNU Emacs 23.2.1 (i386-mingw-nt5.1.2600) of 2010-05-08 on G41R2F1

it does refresh the day view. I can see the "now" line changing.

Also if I go to the line of Monday and press "d" and "g" 
the Agenda stays on Monday.

It seems to me that this bug has been fixed.

Giovanni

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Re: - Bug: [CLOSED ?] Agenda view switches back to week with "g" [7.4]
  2010-12-22 11:54 ` - Bug: [CLOSED ?] " Giovanni Ridolfi
@ 2011-01-26 17:19   ` Michael Brand
  2011-01-26 17:57     ` Joel James Adamson
  2011-01-28 19:55     ` Michael Brand
  0 siblings, 2 replies; 8+ messages in thread
From: Michael Brand @ 2011-01-26 17:19 UTC (permalink / raw)
  To: Giovanni Ridolfi, emacs-orgmode; +Cc: Joel J. Adamson

On Wed, Dec 22, 2010 at 12:54, Giovanni Ridolfi
<giovanni.ridolfi@yahoo.it> wrote:
> adamsonj@email.unc.edu (Joel J. Adamson) writes:
[...]
>> today is Wednesday so pressing "d" brings me the third day of the week.
>> I then press
>> "g" (org-agenda-redo)  which takes me back to week view.
[...]
> It seems to me that this bug has been fixed.

This is still an issue for custom agenda views. With the today's
release_7.4-246-g9658a99 and the test config
(setq org-agenda-custom-commands '(("x" "test" ((agenda)))))
I observe:
- `C-c a a' like expected:
  1) `d g' stays on "view day"
  2) `w f d g' stays on "view day" and also stays on the day of the next week
- `C-c a x' is expected by me to do the same as above but it does:
  1) `d g' switches back to "view week"
  2) `w f d g' switches back to "view week" and changes back to current week

Michael

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Re: - Bug: [CLOSED ?] Agenda view switches back to week with "g" [7.4]
  2011-01-26 17:19   ` Michael Brand
@ 2011-01-26 17:57     ` Joel James Adamson
  2011-01-28 19:55     ` Michael Brand
  1 sibling, 0 replies; 8+ messages in thread
From: Joel James Adamson @ 2011-01-26 17:57 UTC (permalink / raw)
  To: Michael Brand; +Cc: emacs-orgmode


[-- Attachment #1.1: Type: text/plain, Size: 1351 bytes --]

Michael Brand <michael.ch.brand@gmail.com> writes:

> On Wed, Dec 22, 2010 at 12:54, Giovanni Ridolfi
> <giovanni.ridolfi@yahoo.it> wrote:
>> adamsonj@email.unc.edu (Joel J. Adamson) writes:
> [...]
>>> today is Wednesday so pressing "d" brings me the third day of the week.
>>> I then press
>>> "g" (org-agenda-redo)  which takes me back to week view.
> [...]
>> It seems to me that this bug has been fixed.
>
> This is still an issue for custom agenda views. With the today's
> release_7.4-246-g9658a99 and the test config
> (setq org-agenda-custom-commands '(("x" "test" ((agenda)))))
> I observe:
> - `C-c a a' like expected:
>   1) `d g' stays on "view day"
>   2) `w f d g' stays on "view day" and also stays on the day of the next week
> - `C-c a x' is expected by me to do the same as above but it does:
>   1) `d g' switches back to "view week"
>   2) `w f d g' switches back to "view week" and changes back to current week

I forgot to mention that I use the following custom agenda:

(setq org-agenda-custom-commands
      '(("c" "Agenda with Current Projects"
	 ((agenda "")
	  (tags "CURRENT" nil)))))

I am still experiencing this problem on

org-version => 7.4

Joel

-- 
Joel J. Adamson
Servedio Lab
University of North Carolina at Chapel Hill

FSF Member #8164
http://www.unc.edu/~adamsonj

[-- Attachment #1.2: Type: application/pgp-signature, Size: 229 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Re: - Bug: [CLOSED ?] Agenda view switches back to week with "g" [7.4]
  2011-01-26 17:19   ` Michael Brand
  2011-01-26 17:57     ` Joel James Adamson
@ 2011-01-28 19:55     ` Michael Brand
  2011-01-29 10:34       ` Julien Danjou
  1 sibling, 1 reply; 8+ messages in thread
From: Michael Brand @ 2011-01-28 19:55 UTC (permalink / raw)
  To: Org Mode; +Cc: Julien Danjou, Joel J. Adamson

On Wed, Jan 26, 2011 at 18:19, Michael Brand <michael.ch.brand@gmail.com> wrote:
> This is still an issue for custom agenda views. With the today's
> release_7.4-246-g9658a99 and the test config
> (setq org-agenda-custom-commands '(("x" "test" ((agenda)))))
> I observe:
> - `C-c a a' like expected:
>  1) `d g' stays on "view day"
>  2) `w f d g' stays on "view day" and also stays on the day of the next week
> - `C-c a x' is expected by me to do the same as above but it does:
>  1) `d g' switches back to "view week"
>  2) `w f d g' switches back to "view week" and changes back to current week
>
> Michael

In the meantime I did the git bisect for the issue part 1) which is `d
g' switching back from "view day" to "view week":
----------------------------------------------------------------------
$ git describe
release_7.3-168-gc3b2977
$ git bisect good
[...]
$ git describe
release_7.3-169-g0d0edd6
$ git bisect bad
0d0edd6d21ade8e8617c51e3594ea4e87040e05f is first bad commit
commit 0d0edd6d21ade8e8617c51e3594ea4e87040e05f
Author: Julien Danjou <julien@danjou.info>
Date:   Fri Dec 3 16:50:50 2010 +0000

    org-agenda: rework ndays and span handling
[...]
----------------------------------------------------------------------

From a first glance I think that this commit can not be broken into
parts to bisect it further down and I fear that this commit as a whole
is too ambitious for me to contribute more just now.

Michael

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Re: - Bug: [CLOSED ?] Agenda view switches back to week with "g" [7.4]
  2011-01-28 19:55     ` Michael Brand
@ 2011-01-29 10:34       ` Julien Danjou
  2011-01-29 11:27         ` Michael Brand
  0 siblings, 1 reply; 8+ messages in thread
From: Julien Danjou @ 2011-01-29 10:34 UTC (permalink / raw)
  To: Michael Brand; +Cc: Org Mode, Joel J. Adamson


[-- Attachment #1.1: Type: text/plain, Size: 1573 bytes --]

On Fri, Jan 28 2011, Michael Brand wrote:

> On Wed, Jan 26, 2011 at 18:19, Michael Brand <michael.ch.brand@gmail.com> wrote:
>> This is still an issue for custom agenda views. With the today's
>> release_7.4-246-g9658a99 and the test config
>> (setq org-agenda-custom-commands '(("x" "test" ((agenda)))))
>> I observe:
>> - `C-c a a' like expected:
>>  1) `d g' stays on "view day"
>>  2) `w f d g' stays on "view day" and also stays on the day of the next week
>> - `C-c a x' is expected by me to do the same as above but it does:
>>  1) `d g' switches back to "view week"
>>  2) `w f d g' switches back to "view week" and changes back to current week
>>
>> Michael
>
> In the meantime I did the git bisect for the issue part 1) which is `d
> g' switching back from "view day" to "view week":
> ----------------------------------------------------------------------
> $ git describe
> release_7.3-168-gc3b2977
> $ git bisect good
> [...]
> $ git describe
> release_7.3-169-g0d0edd6
> $ git bisect bad
> 0d0edd6d21ade8e8617c51e3594ea4e87040e05f is first bad commit
> commit 0d0edd6d21ade8e8617c51e3594ea4e87040e05f
> Author: Julien Danjou <julien@danjou.info>
> Date:   Fri Dec 3 16:50:50 2010 +0000
>
>     org-agenda: rework ndays and span handling
> [...]
> ----------------------------------------------------------------------

I think that should be fixed by patch 543 which has been forgotten.
Maybe you could try it:

      http://patchwork.newartisans.com/patch/543/

-- 
Julien Danjou
❱ http://julien.danjou.info

[-- Attachment #1.2: Type: application/pgp-signature, Size: 835 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Re: - Bug: [CLOSED ?] Agenda view switches back to week with "g" [7.4]
  2011-01-29 10:34       ` Julien Danjou
@ 2011-01-29 11:27         ` Michael Brand
  2011-01-29 13:33           ` Julien Danjou
  0 siblings, 1 reply; 8+ messages in thread
From: Michael Brand @ 2011-01-29 11:27 UTC (permalink / raw)
  To: Julien Danjou; +Cc: Org Mode, Joel J. Adamson

Hi Julien

Thank you for looking into this.

On Sat, Jan 29, 2011 at 11:34, Julien Danjou <julien@danjou.info> wrote:
>> On Wed, Jan 26, 2011 at 18:19, Michael Brand <michael.ch.brand@gmail.com> wrote:
>>> This is still an issue for custom agenda views. With the today's
>>> release_7.4-246-g9658a99 and the test config
>>> (setq org-agenda-custom-commands '(("x" "test" ((agenda)))))
>>> I observe:
>>> - `C-c a a' like expected:
>>>  1) `d g' stays on "view day"
>>>  2) `w f d g' stays on "view day" and also stays on the day of the next week
>>> - `C-c a x' is expected by me to do the same as above but it does:
>>>  1) `d g' switches back to "view week"
>>>  2) `w f d g' switches back to "view week" and changes back to current week
[...]
> I think that should be fixed by patch 543 which has been forgotten.
> Maybe you could try it:
>      http://patchwork.newartisans.com/patch/543/

The issue part 1) remains after I have applied patch 543 on the
today's release_7.4-259-ge612d0b. Does (setq
org-agenda-custom-commands '(("x" "test" ((agenda))))) and `C-c a x d
g' show the "view day" or "view week" for you?

The issue part 2) has been introduced before your commit mentioned
earlier, I did not yet find the related commit.

Michael

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: Re: - Bug: [CLOSED ?] Agenda view switches back to week with "g" [7.4]
  2011-01-29 11:27         ` Michael Brand
@ 2011-01-29 13:33           ` Julien Danjou
  0 siblings, 0 replies; 8+ messages in thread
From: Julien Danjou @ 2011-01-29 13:33 UTC (permalink / raw)
  To: Michael Brand; +Cc: Org Mode, Joel J. Adamson


[-- Attachment #1.1: Type: text/plain, Size: 693 bytes --]

On Sat, Jan 29 2011, Michael Brand wrote:

>>>>  1) `d g' stays on "view day"

That's expected. If you want to reset the span, you can press 'v space'.

>>>>  2) `w f d g' stays on "view day" and also stays on the day of the
>>>> next week

That's normal, g refresh the agenda, it does not reset the current span.
Press 'v space' to reset it.

>>>> - `C-c a x' is expected by me to do the same as above but it does:
>>>>  1) `d g' switches back to "view week"
>>>>  2) `w f d g' switches back to "view week" and changes back to current week

There's probably something missing in custom agenda view, I'll take a
look.

-- 
Julien Danjou
❱ http://julien.danjou.info

[-- Attachment #1.2: Type: application/pgp-signature, Size: 835 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2011-01-29 13:33 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-21 14:36 Bug: Agenda view switches back to week with "g" [7.4] Joel J. Adamson
2010-12-22 11:54 ` - Bug: [CLOSED ?] " Giovanni Ridolfi
2011-01-26 17:19   ` Michael Brand
2011-01-26 17:57     ` Joel James Adamson
2011-01-28 19:55     ` Michael Brand
2011-01-29 10:34       ` Julien Danjou
2011-01-29 11:27         ` Michael Brand
2011-01-29 13:33           ` Julien Danjou

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).