From: Thomas Baumann <dtbaumann@yahoo.de>
To: emacs-orgmode@gnu.org
Cc: Carsten Dominik <carsten@orgmode.org>
Subject: Re: org-mhe-store-link alters window layout
Date: Tue, 08 Feb 2011 16:44:23 +0100 [thread overview]
Message-ID: <m3fwrycyzs.fsf@norvel.baumann-gauting.site> (raw)
In-Reply-To: 1337.1297074568@maps
Looks good to me, thank you for bringing this up.
Carsten, could you please check the patch in?
Thanks again
Thomas
Stephen Eglen <S.J.Eglen@damtp.cam.ac.uk> writes:
> If I run M-x org-store-link when my current emacs frame is just showing
> one MH-E window (and nothing else in the frame), e.g. the "show-+inbox"
> buffer, then the link to that email is created okay, but the window
> frames are altered so that the +inbox summary window is also shown.
> In general, the previous window contents are forgotten. I suggest
> adding a 'save-window-excursion' into org-mhe-store-link so that the
> window arrangement is preserved on exit from the function.
>
> Patch below is long just because of the extra indentation.
>
> Stephen
>
> diff --git a/lisp/org-mhe.el b/lisp/org-mhe.el
> index c384062..c9b0481 100644
> --- a/lisp/org-mhe.el
> +++ b/lisp/org-mhe.el
> @@ -83,27 +83,28 @@ supported by MH-E."
> "Store a link to an MH-E folder or message."
> (when (or (equal major-mode 'mh-folder-mode)
> (equal major-mode 'mh-show-mode))
> - (let* ((from (org-mhe-get-header "From:"))
> - (to (org-mhe-get-header "To:"))
> - (message-id (org-mhe-get-header "Message-Id:"))
> - (subject (org-mhe-get-header "Subject:"))
> - (date (org-mhe-get-header "Date:"))
> - (date-ts (and date (format-time-string
> - (org-time-stamp-format t) (date-to-time date))))
> - (date-ts-ia (and date (format-time-string
> - (org-time-stamp-format t t)
> - (date-to-time date))))
> - link desc)
> - (org-store-link-props :type "mh" :from from :to to
> - :subject subject :message-id message-id)
> - (when date
> - (org-add-link-props :date date :date-timestamp date-ts
> - :date-timestamp-inactive date-ts-ia))
> - (setq desc (org-email-link-description))
> - (setq link (org-make-link "mhe:" (org-mhe-get-message-real-folder) "#"
> - (org-remove-angle-brackets message-id)))
> - (org-add-link-props :link link :description desc)
> - link)))
> + (save-window-excursion
> + (let* ((from (org-mhe-get-header "From:"))
> + (to (org-mhe-get-header "To:"))
> + (message-id (org-mhe-get-header "Message-Id:"))
> + (subject (org-mhe-get-header "Subject:"))
> + (date (org-mhe-get-header "Date:"))
> + (date-ts (and date (format-time-string
> + (org-time-stamp-format t) (date-to-time date))))
> + (date-ts-ia (and date (format-time-string
> + (org-time-stamp-format t t)
> + (date-to-time date))))
> + link desc)
> + (org-store-link-props :type "mh" :from from :to to
> + :subject subject :message-id message-id)
> + (when date
> + (org-add-link-props :date date :date-timestamp date-ts
> + :date-timestamp-inactive date-ts-ia))
> + (setq desc (org-email-link-description))
> + (setq link (org-make-link "mhe:" (org-mhe-get-message-real-folder) "#"
> + (org-remove-angle-brackets message-id)))
> + (org-add-link-props :link link :description desc)
> + link))))
>
> (defun org-mhe-open (path)
> "Follow an MH-E message link specified by PATH."
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
next prev parent reply other threads:[~2011-02-08 15:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 10:29 org-mhe-store-link alters window layout Stephen Eglen
2011-02-08 15:44 ` Thomas Baumann [this message]
2011-02-08 15:55 ` Bastien
2011-02-08 15:55 ` [Accepted] " Bastien Guerry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fwrycyzs.fsf@norvel.baumann-gauting.site \
--to=dtbaumann@yahoo.de \
--cc=carsten@orgmode.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).