emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Lawrence Mitchell <wence@gmx.li>
To: emacs-orgmode@gnu.org
Subject: [PATCH] org-latex: Don't append newline to end of footnote
Date: Tue, 29 Mar 2011 15:20:54 +0100	[thread overview]
Message-ID: <m339m6ypb9.fsf@e4300lm.epcc.ed.ac.uk> (raw)
In-Reply-To: 4D91DA12.1070707@gmail.com

* lisp/org-latex.el (org-export-latex-preprocess): Don't add a newline
character to a processed footnote.

The extra newline before the closing } character in a footnote
confuses the list parsing code.  The } appears at the beginning of a
line, so it looks like the end of the list.  LaTeX gobbles the space
anyway, so don't add it.
> Hi

> if I export the fiollowing snippet

> * Project Participants
> - Rainer M Krug :: [fn::My email]
> My address

The list is closed incorrectly.  This appears to be a problem in
the interaction between the list parsing and footnote processing
code.  When exporting footnotes, we add a newline at the end, so
in the above example the intermediate file seen by the list
processing code is:

| * Project Participants
| - Rainer M Krug :: \footnote{My email
| }
| My address

The } at the beginning of the line below the list entry is
considered to end the list, so we get:

| * Project Participants
| \begin{description}
| \item[Rainer M Krug] \footnote{My email
| \end{description}
| }
| My address

Note how the description list is ended /inside/ the footnote

Since LaTeX gobbles the trailing space in the footnote anyway, it
makes sense not to insert it in the first place, which this patch
does.  Your test case now exports correctly.



 lisp/org-latex.el |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/lisp/org-latex.el b/lisp/org-latex.el
index 0460a84..3eb54b2 100644
--- a/lisp/org-latex.el
+++ b/lisp/org-latex.el
@@ -2432,9 +2432,7 @@ The conversion is made depending of STRING-BEFORE and STRING-AFTER."
 	       (let ((end (save-excursion
 			    (if (re-search-forward "^$\\|^#.*$\\|\\[[0-9]+\\]" nil t)
 				(match-beginning 0) (point-max)))))
-		 (setq footnote (concat (org-trim (buffer-substring (point) end))
-					; last } won't be part of a link or list.
-					"\n"))
+		 (setq footnote (org-trim (buffer-substring (point) end)))
 		 (delete-region (point) end))
 	       (goto-char foot-beg)
 	       (delete-region foot-beg foot-end)

  reply	other threads:[~2011-03-29 14:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-29 13:09 [BUG] LaTeX export inserts "ORG-LIST-END-MARKER" Rainer M Krug
2011-03-29 14:20 ` Lawrence Mitchell [this message]
2011-03-29 17:38   ` [PATCH] org-latex: Don't append newline to end of footnote Nicolas
2011-03-30  7:49     ` Rainer M Krug
2011-03-30  9:14     ` Lawrence Mitchell
2011-03-30 14:46       ` Rainer M Krug
2011-03-30 22:06         ` Nicolas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m339m6ypb9.fsf@e4300lm.epcc.ed.ac.uk \
    --to=wence@gmx.li \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).