From mboxrd@z Thu Jan  1 00:00:00 1970
From: Phil Rooke <phil@yax.org.uk>
Subject: Re: Unable to clock in on task
Date: Tue, 27 Oct 2009 15:06:36 +0000
Message-ID: <m2zl7c7u6b.fsf@bo.yax.org.uk>
References: <AA7549D7-6CD8-4AAE-9441-C88257CD2532@acm.org>
	<m2skd5non4.fsf@bo.yax.org.uk>
	<3949.1256654208@gamaville.dokosmarshall.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N2ndL-0002cH-3G
	for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 11:06:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N2ndG-0002bG-Mb
	for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 11:06:50 -0400
Received: from [199.232.76.173] (port=34325 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N2ndG-0002bD-CR
	for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 11:06:46 -0400
Received: from mail-bw0-f219.google.com ([209.85.218.219]:44512)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <phil@yax.org.uk>) id 1N2ndF-0004Ts-R2
	for emacs-orgmode@gnu.org; Tue, 27 Oct 2009 11:06:46 -0400
Received: by bwz19 with SMTP id 19so299693bwz.8
	for <emacs-orgmode@gnu.org>; Tue, 27 Oct 2009 08:06:41 -0700 (PDT)
In-Reply-To: <3949.1256654208@gamaville.dokosmarshall.org> (Nick Dokos's
	message of "Tue, 27 Oct 2009 10:36:48 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: nicholas.dokos@hp.com
Cc: Org Mode List <emacs-orgmode@gnu.org>

Nick Dokos <nicholas.dokos@hp.com> writes:

> This does look like a bug: org-resolve-clock calls org-files-list which
> does not know about the "agenda files list in a file" convention.  It
> should probably call the function org-agenda-files instead of
> org-files-list. org-files-list is only used in this one place and should
> probably be deleted.
>
> Try this patch:
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index ea23a8d..2ce2f22 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -737,7 +737,7 @@ non-dangling (i.e., currently open and valid) clocks."
>    (interactive "P")
>    (unless org-clock-resolving-clocks
>      (let ((org-clock-resolving-clocks t))
> -      (dolist (file (org-files-list))
> +      (dolist (file (org-agenda-files))
>  	(let ((clocks (org-find-open-clocks file)))
>  	  (dolist (clock clocks)
>  	    (let ((dangling (or (not (org-clock-is-active))

That works for me.  Thanks a lot.

Phil