From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aPfHAAUdYGGr7QAAgWs5BA (envelope-from ) for ; Fri, 08 Oct 2021 12:27:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8IwPNwQdYGGtDAAAbx9fmQ (envelope-from ) for ; Fri, 08 Oct 2021 10:27:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 89B92F6DA for ; Fri, 8 Oct 2021 12:27:16 +0200 (CEST) Received: from localhost ([::1]:44458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYn5v-0003E1-8C for larch@yhetil.org; Fri, 08 Oct 2021 06:27:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34160) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYn4j-0003Bu-0n for emacs-orgmode@gnu.org; Fri, 08 Oct 2021 06:26:01 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:44622) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mYn4g-0007Vq-88 for emacs-orgmode@gnu.org; Fri, 08 Oct 2021 06:25:59 -0400 Received: by mail-wr1-x436.google.com with SMTP id s15so28331283wrv.11 for ; Fri, 08 Oct 2021 03:25:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=5mC0S7CBxRAIT/aB/lgFMmJi5TDLNqdnn44EiRhNj4U=; b=BepUMDD3tqx2mgF/nmJLMZNACBOLgTTrrMhB5qE1L1F6/HEaf3wSsD/WMkrqPzhWMx PYHwANPHs0dzPKAdWmbKPPWLM2Fel635DmbmerCCNFtY+L7+ipkchJFmwFnkZ/IybbPt 3G0R3Szop0Ot6uE2s1DQFrlUjevaHcPxeVhtXfdjttSqQv+ck3joy5+I7i7P5UEbJ4kX fBezjW/4P3cyx2YAn+eQQrhZA7dlPTTbRWXk9kjN1Do5RbVV3As6zizr7AMgckcNe0tB GIcft8yRO6HZgZopnZcEk0gvltPAIB50/dwjuooQiKqnjilkGCiKZMgbAIGZuDkTkZQp uQSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=5mC0S7CBxRAIT/aB/lgFMmJi5TDLNqdnn44EiRhNj4U=; b=K4LfSbWI/BIznF6Kob3MFjs93cjPdSC+lSir2YoYgZsm8wupxurufAgaiInhigFKr+ mQYEM2Uqx0vf1JI4m70UgAEQIs5iDmzAtvRVVvEk7rTCee0LFwGBb+SSQQo4LR1VNiqX QWxrCT14RMmrtBxPrnj4Y9HYsnEFin8kns86nNuFjFRptdgdPUZaTsN5voowV+/GQU9t mZrsaZhReUOk910H1cOy6bWK1OOsR76rDJHKB8WV9XidQThROyzYJwXckwiLIA1AxDeU 5Trdn+ttA8/I2d2QiQZeW1qp/a/HEZ6+GMuJ6+DI6AjMxLlQ88PcTRaJWk3A1ye/irfx 4s8A== X-Gm-Message-State: AOAM533fFg53sAdeSjizOH7WeG5BNwDE/O0YXKy9mXqmPsxSGtz4HJe8 VHVH0s9gNddBBb4n7sLuf/Zv2IVvyolA9Q== X-Google-Smtp-Source: ABdhPJzbHDSwDHlx+CW2Jef8Ycv+uot6aCkZJNtWgqvlI5UK9wGoxADr6FKtSjhszb/BWqe+wQpoEw== X-Received: by 2002:adf:eb12:: with SMTP id s18mr2989080wrn.97.1633688756553; Fri, 08 Oct 2021 03:25:56 -0700 (PDT) Received: from Home-Mac ([141.226.10.39]) by smtp.gmail.com with ESMTPSA id z18sm2033326wro.25.2021.10.08.03.25.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 03:25:55 -0700 (PDT) From: Daniel Fleischer To: emacs-orgmode@gnu.org Subject: Re: [PATCH] Bug: Tag Selection Face Doesn't Toggle References: Date: Fri, 08 Oct 2021 13:25:54 +0300 In-Reply-To: (Daniel Fleischer's message of "Fri, 08 Oct 2021 13:03:23 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=danflscr@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633688836; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5mC0S7CBxRAIT/aB/lgFMmJi5TDLNqdnn44EiRhNj4U=; b=ljKhd2hOW8NiO+KMACLVC2DOvqxbeo9D7cX4OjsXbp0Ga3Zq1ZLs+BeBSCk9UjLANCeNmI ewH6Ua6d7StJTo9PJLnEPt7TotgD/qAKmqVk3mQHLosoUV7txmpk5NcPO91Nv5gL0Yy9K1 FmUOs2770/D8CgC+U3/n+WRgQt9Au2+3dd8DmTDlX3Cii8HGtKbpVeFs4zbJOEIngdj7nK axlfAFXUJ0d70LRtQTACM7+QhHPvoDEzvy8ONjpAbtqAZxjBLsbBoE4VDNQm3ojGaBSrPe Wo+4ImDnw9sgK/UgPgd5SlqnPKVgT11gUiM79ig3w8fNkBbPLkiQ84FxZ0HhYg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633688836; a=rsa-sha256; cv=none; b=TVvn5Un9aGqKDUf0Cx+/h6GiN3TXPxZMXeYCC8bOMlyWtqo8D9d7jGXt0cMTlEYm7Mn0Uk bpCDJA0Q2quuYqZqrEIlPHbaTiV1v8besoB3d+TmXjZZ28PcD2VDKQ6dLTcZJMk7NvOxUd sNFrxxcR9pDyhj4Y9+GLwpKXSMQYq3t/5LOg/FwGabwRfHU4J0i8gyBkSWXrHVRz/ouig8 3VXcck5CI9G3luhTG/kT0mqzXbGfxMdztDaf0c7B/qWIhIBL8Rfqfxdxp9rME2lSHhYOkZ M33NDfq/SP6zavsHy7RMSh9eyxRyW9Ar5sx7VG/kYXNbsVnTfIiaO3V+pDXkJQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BepUMDD3; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.51 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BepUMDD3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 89B92F6DA X-Spam-Score: -2.51 X-Migadu-Scanner: scn1.migadu.com X-TUID: 4Wiss9RS86PM --=-=-= Content-Type: text/plain > Daniel Fleischer writes: > >> Hi, when selecting tags using fast selection and then de-selecting, the >> face doesn't toggle back to regular face. >> It's better to have a default face instead of 'org-default face. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-lisp-org.el-fast-tag-selection-disabled-tag-face.patch >From f269d3ad99b8ad570c19961831f38653046f07fb Mon Sep 17 00:00:00 2001 From: Daniel Fleischer Date: Fri, 8 Oct 2021 12:55:04 +0300 Subject: [PATCH] lisp/org.el: fast tag selection disabled tag face A tag can be either selected in "current", "inherited" or disabled. When disabled, it should have the 'org-default face. Previously, if a tag was already selected, upon deselection it will still have an 'org-todo face. --- lisp/org.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lisp/org.el b/lisp/org.el index 18cb53af6..1dfe70735 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -12440,8 +12440,7 @@ (defun org-fast-tag-selection (current inherited table &optional todo-table) (cond ((member tag current) c-face) ((member tag inherited) i-face) - (t (get-text-property (match-beginning 1) ' - face)))))))) + (t 'default))))))) (goto-char (point-min))))) (delete-overlay org-tags-overlay) (if rtn -- 2.33.0 --=-=-=--