emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Daniel Fleischer <danflscr@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Bug: Tag Selection Face Doesn't Toggle
Date: Fri, 08 Oct 2021 13:25:54 +0300	[thread overview]
Message-ID: <m2zgrj3j9p.fsf@gmail.com> (raw)
In-Reply-To: <m27den4yvo.fsf@gmail.com> (Daniel Fleischer's message of "Fri, 08 Oct 2021 13:03:23 +0300")

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

> Daniel Fleischer <danflscr@gmail.com> writes:
>> Hi, when selecting tags using fast selection and then de-selecting, the
>> face doesn't toggle back to regular face.

It's better to have a default face instead of 'org-default face.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-org.el-fast-tag-selection-disabled-tag-face.patch --]
[-- Type: text/x-patch, Size: 1001 bytes --]

From f269d3ad99b8ad570c19961831f38653046f07fb Mon Sep 17 00:00:00 2001
From: Daniel Fleischer <danflscr@gmail.com>
Date: Fri, 8 Oct 2021 12:55:04 +0300
Subject: [PATCH] lisp/org.el: fast tag selection disabled tag face

A tag can be either selected in "current", "inherited" or disabled. When
disabled, it should have the 'org-default face. Previously, if a tag was
already selected, upon deselection it will still have an 'org-todo face.
 lisp/org.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 18cb53af6..1dfe70735 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12440,8 +12440,7 @@ (defun org-fast-tag-selection (current inherited table &optional todo-table)
 				((member tag current) c-face)
 				((member tag inherited) i-face)
-				(t (get-text-property (match-beginning 1) '
-						      face))))))))
+				(t 'default)))))))
 		  (goto-char (point-min)))))
 	(delete-overlay org-tags-overlay)
 	(if rtn

      reply	other threads:[~2021-10-08 10:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06 14:48 Bug: Tag Selection Face Doesn't Toggle Daniel Fleischer
2021-10-08 10:03 ` [PATCH] " Daniel Fleischer
2021-10-08 10:25   ` Daniel Fleischer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2zgrj3j9p.fsf@gmail.com \
    --to=danflscr@gmail.com \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).