From mboxrd@z Thu Jan 1 00:00:00 1970 From: a@xkqr.org (Christoffer =?utf-8?Q?Stjernl=C3=B6f?=) Subject: Bug: org-drill-entry-empty-p should use outline-forward-same-level and not outline-next-heading [9.1.6 (9.1.6-48-gfe7619-elpaplus @ /Users/christoffer/.emacs.d/elpa/org-plus-contrib-20180212/)] Date: Fri, 19 Jul 2019 12:56:50 +0200 Message-ID: Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:60259) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoQaT-0003mY-4O for emacs-orgmode@gnu.org; Fri, 19 Jul 2019 06:58:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hoQaR-0001fO-Re for emacs-orgmode@gnu.org; Fri, 19 Jul 2019 06:58:05 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:54003) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hoQaR-0001dZ-Et for emacs-orgmode@gnu.org; Fri, 19 Jul 2019 06:58:03 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7699A20CA5 for ; Fri, 19 Jul 2019 06:58:01 -0400 (EDT) Received: from localhost (vps.xkqr.org [109.74.206.55]) by mail.messagingengine.com (Postfix) with ESMTPA id E2130380076 for ; Fri, 19 Jul 2019 06:58:00 -0400 (EDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See https://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org mailing list. =2D----------------------------------------------------------------------- I have noticed that some of my drill entries are skipped by org-drill, and only recently took the time to try to troubleshoot why =E2=80=93 apparently org-drill-entry-empty-p returns t for my entries, because they look like the following: =2D---- * Entry question? :drill: SCHEDULED: <2019-04-05 Fri> :PROPERTIES: ... :END: ** The Answer Some text =2D--- Since org-drill-entry-empty-p only looks from the end of the metadata/properties and until outline-next-heading, it will consider this drill entry empty =E2=80=93 even though this is not at all my intention. This would be fixed by replacing (outline-next-heading) with (outline-forward-same-level 1) in org-entry-empty-p. I'm not sure whether this has any other adverse effect, but I can't see how it would make things worse, at least. Emacs : GNU Emacs 26.2 (build 1, x86_64-apple-darwin18.6.0, Carbon Version 158 AppKit 1671.5) of 2019-06-15 Package: Org mode version 9.1.6 (9.1.6-48-gfe7619-elpaplus @ /Users/christoffer/.emacs.d/elpa/org-plus-contrib-20180212/) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSnhhl1PrVuOSPiCuJ63EO1dkwMBQUCXTGiNwAKCRB63EO1dkwM BYejAP443nQ5izy4cNFG0Lk2Ja4FGB45Ys+eWJnfUsN9jpD4tQD/UL/y15mBUB3h J3/TQkeKpFdQ08TyGW9xnJUFY6SsvgI= =r86i -----END PGP SIGNATURE----- --=-=-=--