From: Kevin Foley <email@example.com> To: Kyle Meyer <firstname.lastname@example.org> Cc: email@example.com Subject: Re: [PATCH] Org Refile Document RFLOC (was: Org Refile RFLOC and Struct Type) Date: Sun, 18 Oct 2020 21:50:52 -0400 [thread overview] Message-ID: <m2y2k3gf0j.fsf@Kevins-MBP.home.lan> (raw) In-Reply-To: <firstname.lastname@example.org> [-- Attachment #1: Type: text/plain, Size: 993 bytes --] Kyle Meyer <email@example.com> writes: > I imagine tastes vary on whether using cl-defstruct here is an overkill. > (To my eyes, it is.) More importantly, though, I think changing it now > means we'd also need a compatibility layer, which doesn't seem worth the > trouble. I tried implementing it and realized: 1. It have issues with backwards compatibility (like you mentioned). There are some workarounds but they add complexity 2. It can make other things complicated. For example using `assoc' to look things up no longer works so a lot needs to be updated. Personally I think it's worth it as it makes things much clearer but I understand why others may not feel that way and it's not something I feel strongly enough about to push for. > Thanks for noticing and for working on a patch. My pleasure, I've attached a patch to this email. I put something together but I wasn't sure how it should be styled/formatted so if anyone has any suggestions I'd be happy to update it. Kevin [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: 0001-org-refile.el-org-refile-Add-description-of-RFLOC-to.patch --] [-- Type: text/x-patch, Size: 1247 bytes --] From 87af8fc4a08c8b4b2c9c508d0bad0565c0d10429 Mon Sep 17 00:00:00 2001 From: "Kevin J. Foley" <firstname.lastname@example.org> Date: Sun, 18 Oct 2020 21:30:52 -0400 Subject: [PATCH] org-refile.el (org-refile) Add description of RFLOC to docstring --- lisp/org-refile.el | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/lisp/org-refile.el b/lisp/org-refile.el index 7eb0a9643..4d56f2e9a 100644 --- a/lisp/org-refile.el +++ b/lisp/org-refile.el @@ -414,7 +414,16 @@ (defun org-refile (&optional arg default-buffer rfloc msg) Beware that keeping refiled entries may result in duplicated ID properties. -RFLOC can be a refile location obtained in a different way. +RFLOC can be a refile location obtained in a different way. It +should be a list with the following 4 elements: + +1. Name - an identifier for the refile location, typically the +headline text. +2. File - the file the refile location is in +3. nil - Used for generating refile location candidates, not +needed when passing RFLOC +4. Position- the position in the specified file of the +headline to refile under MSG is a string to replace \"Refile\" in the default prompt with another verb. E.g. `org-copy' sets this parameter to \"Copy\". -- 2.28.0
next prev parent reply other threads:[~2020-10-19 1:53 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-13 14:41 Org Refile RFLOC and Struct Type Kevin Foley 2020-10-18 20:16 ` Kyle Meyer 2020-10-19 1:50 ` Kevin Foley [this message] 2020-10-20 4:42 ` [PATCH] Org Refile Document RFLOC (was: Org Refile RFLOC and Struct Type) Kyle Meyer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=m2y2k3gf0j.fsf@Kevins-MBP.home.lan \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] Org Refile Document RFLOC (was: Org Refile RFLOC and Struct Type)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).